Folia support #329
Draft
Folia support #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested some farming/foraging/fighting/archery abilities and everything seems to be working fine for these. Bossbar/actionbar also there, stat/trait reload (hp for example and others that use vanilla attributes) seems also fine. |
|
Required Slate PR to have full functionality |
…egion listener (support side/below)
|
Rebased to the latest state of master. Since that already includes the slate PR, this is now buildable and testable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early implementation for Folia support.
Won't run on Folia yet, since Slate, the GUI API also isn't compatible with Folia yet
For the above reason this build is untested and not production ready
Mainly created this draft PR to discuss the current scheduler handling, potential bugs and stuff I have overlooked, like making the data structures threadsafe.
Of course, for all this to be worth anything, Slate needs to be ported to Folia as well. Since it already uses Paper APIs, it will probably be much easier.