-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the name of IHttpClientContext more concrete #22
Comments
@Maxerdan any thoughts on this? |
It's unnecessary and confusing. |
@Maxerdan I wouldn't say renaming IHttpClientContext is unnecessary. IHttpClientContext does require renaming. |
I don't understand why "Server" should be part of the name. |
ASP.NET has HttpContext class the purpose of which is different |
How about
So in our projects we will have classes like WaiterApiClient, PrimeHillApiClient, Card5ApiClient, ExternalLoyaltyApiClient. |
There's something interesting with an ApiClient naming because that's what it is: an API server and an API client. Some info from the Internet:
|
What is the purpose of IHttpClientContext? Hard to say...
The main idea of IHttpClientContext was to think of this as a server. Why would not to rename IHttpClientContext to IServer then? It'll dramatically increases the idea and understanding of the concept.
The text was updated successfully, but these errors were encountered: