-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in phytoplankton dynamics from v3.1.0a1 to v3.1.1? #34
Comments
Hi Robert https://github.com/AquaticEcoDynamics/libaed2/commits/master/src/aed2_phytoplankton.F90 There is no change to the equations. Perhaps an issue may be vvel, which was changed to m/day to be consistent across the modules. But that wouldn't explain why it came back in 3.2 We always test against our Lake Kinneret reference case and never see changes of this magnitude. When I see this it makes me worry that something is not being read in properly. Also, are zoop configured? As there are many feedbacks, (eg biomass impact clarity and mixing), I think the only way to get to the bottom of this is to cut it back step by step with three versions and see where the main divergence creeps in. ie GLM only. Then GLM+OXY. Then GLM+OXY+PHY ... |
Hi Robert |
Thanks for the feedback, Matt. I ran GLM-only again and the differences in water temp. over all versions are very, very small. 3.1.1 and 3.1.0a1 have the same amounts of layers, where's 3.2.0a4 has slightly more layers over that summer period. Regarding the 10 m averaging before, I took the average from the surface to the depth which was closest to 10 m -- so it could have included 10 m or not (close to the metalimnion, which I see now is a problem). |
I updated my lake models of Lake Mendota to the most recent GLM-AED GitHub versions, but I am getting now different results for water quality variables while running it on the exact same model setup.
I did compile all models using gfortran and Homebrew under macOS Catalna/Big Sur. For the recent versions, GLM was coupled with libaed-water.git instead of libaed2.git.
I extracted all results directly from the NCDF and averaged them over the first 10 m from the water surface (using the z variable and finding the closest value to 10 m).
I expected results to differ a bit (like for temperature), but especially cyanobacteria biomass is completely off between the versions. Were there some significant source code changes for aed_phytoplankton.F90, or changes in parameterizations?
The text was updated successfully, but these errors were encountered: