Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts: change the representation of layout trees #40

Open
Antikyth opened this issue Nov 22, 2023 · 0 comments
Open

Layouts: change the representation of layout trees #40

Antikyth opened this issue Nov 22, 2023 · 0 comments
Labels
implementations An existing feature or necessary functionality is further implemented layouts Issues and PRs related to Layout Managers in AquariWM. rewrite Rewrites to large sections of code

Comments

@Antikyth
Copy link
Member

Working with layouts is complicated a lot by my representation of the layout tree. While it is the most obvious way to represent a tree, I understand now that there are other ways, and ways that will make other layout features that need to be implemented easier.

The main complication with these layouts is that each group has a lot more information than just its children (orientation, dimensions, coordinates at minimum).

I think a better approach here, which I haven't learned that much about yet, is to somehow use Rc and Weak to let nodes have references to their parents. I'm not sure how mutating groups' orientation, dimensions, and coordinates fits in with that.

@Antikyth Antikyth added rewrite Rewrites to large sections of code implementations An existing feature or necessary functionality is further implemented layouts Issues and PRs related to Layout Managers in AquariWM. labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementations An existing feature or necessary functionality is further implemented layouts Issues and PRs related to Layout Managers in AquariWM. rewrite Rewrites to large sections of code
Projects
None yet
Development

No branches or pull requests

1 participant