Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity Compiler Not Installed When Running Tests #54

Closed
ghost opened this issue Jul 6, 2022 · 2 comments · Fixed by #55
Closed

Solidity Compiler Not Installed When Running Tests #54

ghost opened this issue Jul 6, 2022 · 2 comments · Fixed by #55
Labels
category: bug Something isn't working size: 2 pieces Relatively easy, but requires some thought

Comments

@ghost
Copy link

ghost commented Jul 6, 2022

Environment information

  • OS: macOS 10.14.6
  • Python Version: 3.9.13
  • ape and plugin versions:
$ ape --version
0.3.5.dev1+gcf0ee464

$ ape plugins list
Installed Plugins:
  template    0.3.0
  solidity    0.3.1
  alchemy     0.3.0
  vyper       0.3.0
  • Contents of your ape-config.yaml (NOTE: do not post anything private like RPC urls or secrets!):
$ cat ape-config.yaml
plugins:
  - name: solidity

What went wrong?

Running tests without any changes errors if the relevant solc versions are not installed for the contracts attempting to be compiled by the tests

How can it be fixed?

Looks like it's a false-positive issue when checking if a version of solc is installed, compiler.py:411 likely

@ghost ghost added category: bug Something isn't working size: 2 pieces Relatively easy, but requires some thought labels Jul 6, 2022
@ghost ghost self-assigned this Jul 6, 2022
@ghost
Copy link
Author

ghost commented Jul 6, 2022

This came about from submitting #53 and noticing that the tests there were failing

@ghost
Copy link
Author

ghost commented Jul 8, 2022

There's a separate, blocking issue with Solidity for M1 Macs, detailed at ApeWorX/py-solc-x#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working size: 2 pieces Relatively easy, but requires some thought
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants