-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#268: Create context for reloading sidebar data #269
base: master
Are you sure you want to change the base?
#268: Create context for reloading sidebar data #269
Conversation
@AntonioMrtz Could you please review my pull request and merge it? I'm a beginner and have done my best to deliver. Thank you! |
Hi @yashwanthvarma18 , thanks for your work, I will try to review it ASAP :) . We have a list of contributors in I runned the pipelines, it seems like eslint, prettier and some tests are failing. Can you take a look at it? Let me know if you need any help |
@AntonioMrtz |
If you go inside details for each failed pipeline you can see the error logs. To reproduce it locally run the follow commands:
|
@AntonioMrtz |
@AntonioMrtz what can i do to correct this |
@AntonioMrtz Please check the new commit and let me know if there is any issue again |
Hi @yashwanthvarma18 , just a few things: I know it probably took some time to do the adjustments but we don't want all the external .erb packages, markdown doc files and more to use frontend prettier format. Also I found that many rules that we don't use are being applied. I'm confident to say that this can be due to running As you can see here, the custom commands that run with "scripts": {
"lint": "cross-env NODE_ENV=development eslint src/ --ext .js,.jsx,.ts,.tsx --fix",
"format:write": "prettier src/ --write --ignore-path .prettierignore",
} Example with What would I do:
Let me know if you have any question, code looked good but I cannot merge a lot of modified files that were out of scope for this task :) |
@AntonioMrtz |
Yeah, I checked the changes and know they have took a long time to implement. I feel bad for it :( , but we have to keep the codebase with the same style and format |
Description
This pull request introduces a new context for managing sidebar data across the application. The goal is to streamline the refresh of sidebar data by avoiding prop drilling and making the refreshSidebarData method accessible from any component in the app.
Commit type
featIssue
#268
The current implementation requires prop drilling to access the refreshSidebarData method in various components, making the codebase cumbersome and less maintainable.
Solution
We have created a context that provides the refreshSidebarData method, allowing any component to access it directly without passing it through several layers of components.
Proposed Changes
Potential Impact
These changes will enhance the maintainability of the application by reducing the complexity of prop passing. There is a potential for minor adjustments needed in components that previously relied on direct props, but it improves the overall structure and accessibility of the sidebar data functionality.
Additional Tasks
Assigned
@AntonioMrtz