Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Player component selection depending on selected architecture. #132

Open
AntonioMrtz opened this issue Apr 25, 2024 · 1 comment
Labels
frontend Frontend related issues good first issue Good for newcomers hacktoberfest hacktoberfest help-wanted Help is wanted

Comments

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Apr 25, 2024

Description

Improve the selection of the Player Component depending on the selected architecture

Context

In file global.ts theres a variable that controls which Music Player component the app has to load

export const songArchitecture: SongArchitecture =
    SongArchitecture.BLOB_ARCHITECTURE;

In the Footer componnent theres an if statement hardcoded that chooses between 2 components depending on the architecture selected. The goal is to improve this component selection using composition

How to do it

Use composition instead of the current if-else

Testing

Make a test in a new file called ArchitectureSelection.test.tsx that:

  • Loads global.ts with architecture SERVERLESS_ARCHITECTURE and check if the associated component is loaded
  • Same with BLOB_ARCHITECTURE
@AntonioMrtz AntonioMrtz added good first issue Good for newcomers frontend Frontend related issues test Changes or improvements to tests help-wanted Help is wanted labels Apr 25, 2024
@AntonioMrtz AntonioMrtz pinned this issue Apr 25, 2024
@AntonioMrtz AntonioMrtz removed the test Changes or improvements to tests label May 11, 2024
@AntonioMrtz AntonioMrtz unpinned this issue Jun 30, 2024
@AntonioMrtz AntonioMrtz pinned this issue Jun 30, 2024
@AntonioMrtz AntonioMrtz unpinned this issue Jul 7, 2024
@AntonioMrtz AntonioMrtz pinned this issue Sep 8, 2024
@AntonioMrtz AntonioMrtz unpinned this issue Sep 30, 2024
@AntonioMrtz AntonioMrtz added the hacktoberfest hacktoberfest label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related issues good first issue Good for newcomers hacktoberfest hacktoberfest help-wanted Help is wanted
Projects
None yet
Development

No branches or pull requests

1 participant