Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail-now: suggest t.Fatalf instead of weird assertions #144

Open
Antonboom opened this issue Jun 21, 2024 · 0 comments
Open

fail-now: suggest t.Fatalf instead of weird assertions #144

Antonboom opened this issue Jun 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Antonboom
Copy link
Owner

Need to find more cases like:

https://github.com/kubernetes/kubernetes/blob/5ec31e84d6c525c173906b1497ee6f075c1926e9/pkg/controller/podautoscaler/horizontal_test.go#L760
@Antonboom Antonboom added the enhancement New feature or request label Jun 21, 2024
@Antonboom Antonboom changed the title fail-now: suggest t.Fatalf instead of weird assertions fail-now: suggest t.Fatalf instead of weird assertions Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Antonboom