Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when calling fetchOrder with insurance configured #34

Open
svenbw opened this issue May 24, 2023 · 2 comments
Open

Exception when calling fetchOrder with insurance configured #34

svenbw opened this issue May 24, 2023 · 2 comments

Comments

@svenbw
Copy link

svenbw commented May 24, 2023

When the fetchOrder is called on an order with insurance the createFromXML in Bpost\BpostApiClient\Bpost\Order\Box\Option\Insured failes.

It can be resolved using getting the children with the full namespace:

// $insuranceDetail = $xml->children('common', true); <-- fails
$insuranceDetail = $xml->children('http://schema.post.be/shm/deepintegration/v3/common');

Environment: PHP 8.2.6

dave-driesmans added a commit to dave-driesmans/bpost-api-library that referenced this issue Jan 11, 2024
@dave-driesmans
Copy link

dave-driesmans commented Jan 11, 2024

+1
Had to fork the master.
Also the version with the 3.4.11 tag does not work for insured packages

Thanks!

@kouinkouin
Copy link
Member

Hi,

Sorry for the very late reply.

There were 2 bugs:

  • As you said, the Insured option was wrongly loaded
  • All options were not loaded (only the first)

These 2 bugs are solved in #44 (merged on master).
Can you check that solve your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants