Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets Update DLC12 (GU16) #445

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

oliversaggau
Copy link

@oliversaggau oliversaggau commented Jan 30, 2023

There are a few open topics left here:

  • I didn't know whether to increase the version number of the presets.json so I only copied the new building presets and left everything else unchanged
  • I had no idea how the colors.json is maintained/generated or where you guys got you colors for the existing buildings, I could only manually edit the colors.json and add the new buildings to the colors I think match best
  • I added some new group names, the translations for this apperantly come from https://docs.google.com/spreadsheets/d/1CjECty43mkkm1waO4yhQl1rzZ-ZltrBgj00aq-WJX4w/edit?usp=sharing but I didn't know what to do and didn't just want to mess around in there, so I'll just post them here:
eng		(21) Artista
pol		(21) Artysta
ger		(21) Artista
fra		(21) Artiste
rus		(21) Артиста
esp		(21) Artista

eng		29 Old Town
pol		29 Stare Miasto
ger		29 Altstadt
fra		29 Vieille ville
rus		29 Старый город
esp		29 Ciudad antigua

eng		30 Dragon Garden
pol		30 Smoczy ogród
ger		30 Drachengarten
fra		30 Jardin du dragon
rus		30 Сад дракона
esp		30 Jardín del dragón

eng		31 Beach Ornaments
pol		31 Ozdoby plaży
ger		31 Strandornamente
fra		31 Embellissements de plage
rus		31 Декоративные элементы (пляж)
esp		31 Adornos de playa

eng		(33) Scenario 4: Pride & Peddlers
pol		(33) Scenariusz 4: Duma i przedsiębiorczość
ger		(33) Szenario 4: Stolz und Marktanteil
fra		(33) Scénario 4 : Orgueil et parts de marché
rus		(33) Сценарий 4: Гордость и продажи
esp		(33) Escenario 4: Orgullo y beneficio

@@ -13,7 +13,7 @@ namespace PresetParser.Anno1800
/// ChangeBuildingTo<1>_<2>_1800
/// <1> can be : OW (All Worlds) - OW1 (New World - (1) Farmers) - OW2 (New World - (2) Workers) - OW3 (New World - (3) Artisans)
/// OW4 (New World - (4) Engineers - OW5 (New World - (5) Investors) - OW6 (New World (13) Scholars)
/// NW1 (Old World - (7) Jornaleros - NW2 (Old World - (8) Obreros)
/// NW1 (Old World - (7) Jornaleros - NW2 (Old World - (8) Obreros - NW3 (Old World - (21) Artista)
Copy link
Author

@oliversaggau oliversaggau Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow feels kind of off to have (7) Jornaleros and (8) Obreros in the menu right next to each other, and then way later (21) Artista. But (9) ... was already taken and (21) the next one that was free 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant