Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List item spacing problem when previous item ends with an equation #30

Open
rjw62 opened this issue Nov 6, 2019 · 3 comments
Open

List item spacing problem when previous item ends with an equation #30

rjw62 opened this issue Nov 6, 2019 · 3 comments
Assignees
Labels
Confirmed Yup, it's really an issue associated with accessibility.

Comments

@rjw62
Copy link

rjw62 commented Nov 6, 2019

When using this v2.0.3 of this package with the taggedoption, if a list item is ended by an equation, which is then followed by another list item, then too much vertical space is inserted between the equation and the following list item. I've made a minimal-ish example at https://archive.uea.ac.uk/~aqw10chu/files/access.tex with the pdflatex-generated output at https://archive.uea.ac.uk/~aqw10chu/files/access.pdf

I've had a play around with the code in accessibility.sty, and the problem seems to be in the end part of the PDFSpezialTextObj environment. The closest I've been able to get fixing the issue is to add \ignorespaces to the end of the environment's definition, and commenting out the \pdfrefobj \theTextObjNum% line completely. This then fixes the spacing issue. But presumably that line is needed, and I couldn't find how to include it without messing up the spacing again.

@AndyClifton
Copy link
Owner

Thanks for this. I've used this as an excuse to set up a Tests directory. This used to be 'samples', but that seemed a bit optimistic.

This issue is now implemented as the tests/article/itemizeandequation.tex test.

I've confirmed that its the accessibility package doing this by commenting out \usepackage{accessibility}. When I do that, the spacing returns to normal.

@AndyClifton
Copy link
Owner

@rjw62 : when you say you've mitigated that by making some changes, could you give me a bit more of a hint please where in the file you are? Line numbers for the lines you reference would be very handy. Thanks!

@AndyClifton AndyClifton added the Confirmed Yup, it's really an issue associated with accessibility. label Nov 8, 2019
@rjw62
Copy link
Author

rjw62 commented Nov 9, 2019

On accessibility.sty , as it currently is at https://github.com/AndyClifton/accessibility/blob/master/source/v2x/accessibility.sty , I added \ignorespaces on a new line between existing lines 358 and 359, and also commented out completely line 351 (\pdfrefobj \theTextObjNum%). Both of these were needed at the same time to remove the spacing problem. The first change should be fine to make permanently. The second one presumably removes some important functionality, and so can't be used in a fix for this bug. But it hopefully narrows down where the problem lies.

AndyClifton added a commit that referenced this issue Nov 9, 2019
Added a tests directory. This used to contain some of the samples, but that feels optimistic. I've now implemented a few basic unit tests.

Change prompted by issue #30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Yup, it's really an issue associated with accessibility.
Projects
None yet
Development

No branches or pull requests

2 participants