Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting “python_requires” with ">=3.5" is a better way to declare Python compatibility #253

Open
PyVCEchecker opened this issue Oct 27, 2022 · 1 comment

Comments

@PyVCEchecker
Copy link

PyVCEchecker commented Oct 27, 2022

Hello!
I notice that the dependency of this distribution

install_requires=["Django >=2.1"]

I found that Django>=2.1 requires Python>=3.5 , and you declare supported python:3.5+ in README.
I guess you want to set python>=3.5. But I think it is a better way to declare Python compatibility by using the keyword argument python_requires than declaring that in README.rst:

  • Descriptions in python_requires will be reflected in the metadata
  • “pip install” can check such metadata on the fly during distribution selection , and prevent from downloading and installing the incompatible package versions.
  • If the user does not specify any version constraint, pip can automatically choose the latest compatible package version for users.

Way to improve:
modify setup() in setup.py, add python_requires keyword argument:

setup(…
     python_requires=">=3.5",
     …)

Thanks for your attention.
Best regrads,
PyVCEchecker

@jonashaag
Copy link
Collaborator

Thanks, can you create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants