From 0c63a30670fdb97e7ce2857470a2f70e32f43807 Mon Sep 17 00:00:00 2001 From: Andreas Date: Mon, 23 Sep 2024 08:42:37 +0200 Subject: [PATCH] Fixed `SwitchHeaderConventView` This commit fixes issues with the `SwitchHeaderConventView`. Fixed #566 --- common.props | 2 +- .../SortFilterHeaderConventView.xaml | 148 ------------ .../SortFilterHeaderConventView.xaml.cs | 103 --------- .../ContentViews/SwitchHeaderConventView.xaml | 73 ------ .../SwitchHeaderConventView.xaml.cs | 81 ------- ...redMauiXamlStylesLibrary.Syncfusion.csproj | 9 - .../SortFilterHeaderConventView.xaml | 214 ++++++++---------- .../SortFilterHeaderConventView.xaml.cs | 3 + .../ContentViews/SwitchHeaderConventView.xaml | 60 +---- .../TitleViewAccountConventView.xaml | 1 - 10 files changed, 104 insertions(+), 590 deletions(-) delete mode 100644 src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml delete mode 100644 src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml.cs delete mode 100644 src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml delete mode 100644 src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml.cs diff --git a/common.props b/common.props index 5eeb3fd8..969f62b1 100644 --- a/common.props +++ b/common.props @@ -1,7 +1,7 @@ - 1.2.14 + 1.2.13.2 ar_128.png en https://github.com/AndreasReitberger/SharedMauiXamlStyles diff --git a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml b/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml deleted file mode 100644 index 9c1cd222..00000000 --- a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml +++ /dev/null @@ -1,148 +0,0 @@ - - - - - - - - - - - - - - - - - diff --git a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml.cs b/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml.cs deleted file mode 100644 index eec0e511..00000000 --- a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SortFilterHeaderConventView.xaml.cs +++ /dev/null @@ -1,103 +0,0 @@ -using System.Windows.Input; -using AndreasReitberger.Shared.Syncfusion.FontIcons; - -namespace AndreasReitberger.Shared.Syncfusion.ContentViews; - -[Obsolete("Use the view from `AndreasReitberger.Shared.ContentViews` instead")] -public partial class SortFilterHeaderConventView : ContentView -{ - #region Bindings - - public static readonly BindableProperty IsFilteredProperty = BindableProperty.Create(nameof(IsFiltered), typeof(bool), typeof(SortFilterHeaderConventView), false); - public static readonly BindableProperty ShowFilterButtonProperty = BindableProperty.Create(nameof(ShowFilterButton), typeof(bool), typeof(SortFilterHeaderConventView), true); - - public static readonly BindableProperty ButtonIconFontFamilyProperty = BindableProperty.Create(nameof(ButtonIconFontFamily), typeof(string), typeof(SortFilterHeaderConventView), "UIFontIcons"); - public static readonly BindableProperty CommandParameterProperty = BindableProperty.Create(nameof(CommandParameter), typeof(object), typeof(SortFilterHeaderConventView), null); - - public static readonly BindableProperty SortButtonTextProperty = BindableProperty.Create(nameof(SortButtonText), typeof(string), typeof(SortFilterHeaderConventView), string.Empty); - public static readonly BindableProperty FilterButtonTextProperty = BindableProperty.Create(nameof(FilterButtonText), typeof(string), typeof(SortFilterHeaderConventView), string.Empty); - - public static readonly BindableProperty SortButtonIconTextProperty = BindableProperty.Create(nameof(SortButtonIconText), typeof(string), typeof(SortFilterHeaderConventView), SyncfusionIcons.Sort); - public static readonly BindableProperty FilterButtonIconTextProperty = BindableProperty.Create(nameof(FilterButtonIconText), typeof(string), typeof(SortFilterHeaderConventView), SyncfusionIcons.Filter); - public static readonly BindableProperty ClearButtonIconTextProperty = BindableProperty.Create(nameof(ClearButtonIconText), typeof(string), typeof(SortFilterHeaderConventView), SyncfusionIcons.Close); - - public static readonly BindableProperty SortButtonCommandProperty = BindableProperty.Create(nameof(SortButtonCommand), typeof(ICommand), typeof(SortFilterHeaderConventView), null); - public static readonly BindableProperty FilterButtonCommandProperty = BindableProperty.Create(nameof(FilterButtonCommand), typeof(ICommand), typeof(SortFilterHeaderConventView), null); - public static readonly BindableProperty ClearButtonCommandProperty = BindableProperty.Create(nameof(ClearButtonCommand), typeof(ICommand), typeof(SortFilterHeaderConventView), null); - - #endregion - - #region Properties - public string SortButtonText - { - get => (string)GetValue(SortButtonTextProperty); - set => SetValue(SortButtonTextProperty, value); - } - public string FilterButtonText - { - get => (string)GetValue(FilterButtonTextProperty); - set => SetValue(FilterButtonTextProperty, value); - } - - public string SortButtonIconText - { - get => (string)GetValue(SortButtonIconTextProperty); - set => SetValue(SortButtonIconTextProperty, value); - } - public string FilterButtonIconText - { - get => (string)GetValue(FilterButtonIconTextProperty); - set => SetValue(FilterButtonIconTextProperty, value); - } - public string ClearButtonIconText - { - get => (string)GetValue(ClearButtonIconTextProperty); - set => SetValue(ClearButtonIconTextProperty, value); - } - - public string ButtonIconFontFamily - { - get => (string)GetValue(ButtonIconFontFamilyProperty); - set => SetValue(ButtonIconFontFamilyProperty, value); - } - public object CommandParameter - { - get => (object)GetValue(CommandParameterProperty); - set => SetValue(CommandParameterProperty, value); - } - - - public bool IsFiltered - { - get => (bool)GetValue(IsFilteredProperty); - set => SetValue(IsFilteredProperty, value); - } - - public bool ShowFilterButton - { - get => (bool)GetValue(ShowFilterButtonProperty); - set => SetValue(ShowFilterButtonProperty, value); - } - - public ICommand SortButtonCommand - { - get => (ICommand)GetValue(SortButtonCommandProperty); - set => SetValue(SortButtonCommandProperty, value); - } - public ICommand FilterButtonCommand - { - get => (ICommand)GetValue(FilterButtonCommandProperty); - set => SetValue(FilterButtonCommandProperty, value); - } - public ICommand ClearButtonCommand - { - get => (ICommand)GetValue(ClearButtonCommandProperty); - set => SetValue(ClearButtonCommandProperty, value); - } - #endregion - - public SortFilterHeaderConventView() - { - InitializeComponent(); - } -} \ No newline at end of file diff --git a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml b/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml deleted file mode 100644 index b16bb4d3..00000000 --- a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml +++ /dev/null @@ -1,73 +0,0 @@ - - - - - - - - - - diff --git a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml.cs b/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml.cs deleted file mode 100644 index bbe4ecdc..00000000 --- a/src/SharedMauiXamlStylesLibrary.Syncfusion/ContentViews/SwitchHeaderConventView.xaml.cs +++ /dev/null @@ -1,81 +0,0 @@ -using AndreasReitberger.Shared.FontIcons; -using System.Windows.Input; - -namespace AndreasReitberger.Shared.Syncfusion.ContentViews; - -public partial class SwitchHeaderConventView : ContentView -{ - #region Bindings - - public static readonly BindableProperty ButtonIconFontFamilyProperty = BindableProperty.Create(nameof(ButtonIconFontFamily), typeof(string), typeof(SwitchHeaderConventView), "MaterialDesignIcons"); - - public static readonly BindableProperty BackButtonTextProperty = BindableProperty.Create(nameof(BackButtonText), typeof(string), typeof(SwitchHeaderConventView), string.Empty); - public static readonly BindableProperty NextButtonTextProperty = BindableProperty.Create(nameof(NextButtonText), typeof(string), typeof(SwitchHeaderConventView), string.Empty); - - public static readonly BindableProperty TitleLabelTextProperty = BindableProperty.Create(nameof(TitleLabelText), typeof(string), typeof(SwitchHeaderConventView), null); - public static readonly BindableProperty TitleLabelFormattedStringProperty = BindableProperty.Create(nameof(TitleLabelFormattedString), typeof(FormattedString), typeof(SwitchHeaderConventView), null); - - public static readonly BindableProperty BackButtonIconTextProperty = BindableProperty.Create(nameof(BackButtonIconText), typeof(string), typeof(SwitchHeaderConventView), MaterialIcons.Filter); - public static readonly BindableProperty NextButtonIconTextProperty = BindableProperty.Create(nameof(NextButtonIconText), typeof(string), typeof(SwitchHeaderConventView), MaterialIcons.Sort); - - public static readonly BindableProperty BackButtonCommandProperty = BindableProperty.Create(nameof(BackButtonCommand), typeof(ICommand), typeof(SwitchHeaderConventView), null); - public static readonly BindableProperty NextButtonCommandProperty = BindableProperty.Create(nameof(NextButtonCommand), typeof(ICommand), typeof(SwitchHeaderConventView), null); - - #endregion - - #region Properties - public string BackButtonText - { - get => (string)GetValue(BackButtonTextProperty); - set => SetValue(BackButtonTextProperty, value); - } - public string NextButtonText - { - get => (string)GetValue(NextButtonTextProperty); - set => SetValue(NextButtonTextProperty, value); - } - public string TitleLabelText - { - get => (string)GetValue(TitleLabelTextProperty); - set => SetValue(TitleLabelTextProperty, value); - } - public FormattedString TitleLabelFormattedString - { - get => (FormattedString)GetValue(TitleLabelFormattedStringProperty); - set => SetValue(TitleLabelFormattedStringProperty, value); - } - - public string NextButtonIconText - { - get => (string)GetValue(NextButtonIconTextProperty); - set => SetValue(NextButtonIconTextProperty, value); - } - public string BackButtonIconText - { - get => (string)GetValue(BackButtonIconTextProperty); - set => SetValue(BackButtonIconTextProperty, value); - } - - public string ButtonIconFontFamily - { - get => (string)GetValue(ButtonIconFontFamilyProperty); - set => SetValue(ButtonIconFontFamilyProperty, value); - } - - public ICommand BackButtonCommand - { - get => (ICommand)GetValue(BackButtonCommandProperty); - set => SetValue(BackButtonCommandProperty, value); - } - public ICommand NextButtonCommand - { - get => (ICommand)GetValue(NextButtonCommandProperty); - set => SetValue(NextButtonCommandProperty, value); - } - #endregion - - public SwitchHeaderConventView() - { - InitializeComponent(); - } -} \ No newline at end of file diff --git a/src/SharedMauiXamlStylesLibrary.Syncfusion/SharedMauiXamlStylesLibrary.Syncfusion.csproj b/src/SharedMauiXamlStylesLibrary.Syncfusion/SharedMauiXamlStylesLibrary.Syncfusion.csproj index 7b590a71..481a87f1 100644 --- a/src/SharedMauiXamlStylesLibrary.Syncfusion/SharedMauiXamlStylesLibrary.Syncfusion.csproj +++ b/src/SharedMauiXamlStylesLibrary.Syncfusion/SharedMauiXamlStylesLibrary.Syncfusion.csproj @@ -69,9 +69,6 @@ - - %(Filename) - AccountConventView.xaml @@ -118,12 +115,6 @@ - - MSBuild:Compile - - - MSBuild:Compile - MSBuild:Compile diff --git a/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml b/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml index 14e71a40..2fdc9a32 100644 --- a/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml +++ b/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml @@ -7,135 +7,109 @@ - - - - - - - - + + + + + + diff --git a/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml.cs b/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml.cs index 2bc55f6f..a2353d9c 100644 --- a/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml.cs +++ b/src/SharedMauiXamlStylesLibrary/ContentViews/SortFilterHeaderConventView.xaml.cs @@ -8,6 +8,8 @@ public partial class SortFilterHeaderConventView : ContentView #region Bindings public static readonly BindableProperty IsFilteredProperty = BindableProperty.Create(nameof(IsFiltered), typeof(bool), typeof(SortFilterHeaderConventView), false); + + [Obsolete("Use `HeightRequest` instead")] public static readonly BindableProperty ContainerHeightProperty = BindableProperty.Create(nameof(ContainerHeight), typeof(int), typeof(SortFilterHeaderConventView), 45); public static readonly BindableProperty ShowFilterButtonProperty = BindableProperty.Create(nameof(ShowFilterButton), typeof(bool), typeof(SortFilterHeaderConventView), true); @@ -72,6 +74,7 @@ public bool IsFiltered set => SetValue(IsFilteredProperty, value); } + [Obsolete("Use `HeightRequest` instead")] public int ContainerHeight { get => (int)GetValue(ContainerHeightProperty); diff --git a/src/SharedMauiXamlStylesLibrary/ContentViews/SwitchHeaderConventView.xaml b/src/SharedMauiXamlStylesLibrary/ContentViews/SwitchHeaderConventView.xaml index be3169c7..24030436 100644 --- a/src/SharedMauiXamlStylesLibrary/ContentViews/SwitchHeaderConventView.xaml +++ b/src/SharedMauiXamlStylesLibrary/ContentViews/SwitchHeaderConventView.xaml @@ -7,6 +7,7 @@