From c6ed75b5948e1e703047c7fa5b64bb4f18c6bee4 Mon Sep 17 00:00:00 2001 From: Eli <88557639+lishaduck@users.noreply.github.com> Date: Sun, 10 Nov 2024 22:06:44 -0600 Subject: [PATCH 1/2] chore: comment out caching recommendation --- apps/docs-website/docs/performance-considerations.mdx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/docs-website/docs/performance-considerations.mdx b/apps/docs-website/docs/performance-considerations.mdx index 00f9335c..7105a7cc 100644 --- a/apps/docs-website/docs/performance-considerations.mdx +++ b/apps/docs-website/docs/performance-considerations.mdx @@ -102,14 +102,15 @@ export default defineFlatConfig([ This is a tradeoff, as this approach is a DX degradation and could lead to some developer frustration, because perfectly valid code in local environment could instead fail in CI. -### Adopt ESLint cache +{/* Caching doesn't handles dependencies, breaking typescript-eslint and eslint-plugin-import: https://typescript-eslint.io/troubleshooting/faqs/eslint/#can-i-use-eslints---cache-with-typescript-eslint */} +{/* ### Adopt ESLint's cache ESLint features an internal cache where you can store your previous runs. This technique has pretty much no downsides and you should employ it in any case, regardless of any other factor. Read the official docs on ESLint caching here: [command-line-interface#caching](https://eslint.org/docs/latest/use/command-line-interface#caching).
-Instead, if your project lives in a monorepo, you can follow [this guide](https://www.shew.dev/monorepos/guardrails/eslint). +Instead, if your project lives in a monorepo, you can follow [this guide](https://www.shew.dev/monorepos/guardrails/eslint). */} ### Review glob patterns From b403185cfd8e9a9395d85b3d311866a2e04522d1 Mon Sep 17 00:00:00 2001 From: Eli <88557639+lishaduck@users.noreply.github.com> Date: Sun, 10 Nov 2024 22:07:07 -0600 Subject: [PATCH 2/2] chore: remove eslint caching --- apps/config-validation-playground/package.json | 2 +- apps/docs-website/package.json | 2 +- apps/sheriff-webservices/package.json | 2 +- packages/sheriff-cli/package.json | 2 +- packages/sheriff-create-config/package.json | 2 +- turbo.json | 2 -- 6 files changed, 5 insertions(+), 7 deletions(-) diff --git a/apps/config-validation-playground/package.json b/apps/config-validation-playground/package.json index 7d222d58..3a4333ba 100644 --- a/apps/config-validation-playground/package.json +++ b/apps/config-validation-playground/package.json @@ -5,7 +5,7 @@ "type": "module", "packageManager": "pnpm@9.7.1", "scripts": { - "validate-config": "eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/.eslintcache" + "validate-config": "eslint . --max-warnings=0" }, "dependencies": { "astro": "^4.12.2", diff --git a/apps/docs-website/package.json b/apps/docs-website/package.json index 5523fb3f..96b4e0a5 100644 --- a/apps/docs-website/package.json +++ b/apps/docs-website/package.json @@ -12,7 +12,7 @@ "write-translations": "docusaurus write-translations", "write-heading-ids": "docusaurus write-heading-ids", "typecheck": "tsc --noEmit", - "lint": "eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/.eslintcache", + "lint": "eslint . --max-warnings=0", "typesync": "typesync --dry=fail", "clean": "pnpm clear && rm -rf .turbo dist node_modules/.cache" }, diff --git a/apps/sheriff-webservices/package.json b/apps/sheriff-webservices/package.json index a911c8f8..5bc7bee3 100644 --- a/apps/sheriff-webservices/package.json +++ b/apps/sheriff-webservices/package.json @@ -7,7 +7,7 @@ "start": "tsx watch ./src/index.ts", "build": "tsc", "typecheck": "tsc --noEmit", - "lint": "eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/.eslintcache", + "lint": "eslint . --max-warnings=0", "typesync": "typesync --dry=fail", "serve": "node ./dist/index.js", "clean": "rm -rf .turbo dist node_modules/.cache" diff --git a/packages/sheriff-cli/package.json b/packages/sheriff-cli/package.json index be91364d..be1fad93 100644 --- a/packages/sheriff-cli/package.json +++ b/packages/sheriff-cli/package.json @@ -8,7 +8,7 @@ "clean": "rm -rf .turbo dist node_modules/.cache", "build": "tsup", "typecheck": "tsc --noEmit", - "lint": "eslint ./src --max-warnings=0 --cache --cache-location=node_modules/.cache/.eslintcache", + "lint": "eslint ./src --max-warnings=0", "publint": "publint", "typesync": "typesync --dry=fail" }, diff --git a/packages/sheriff-create-config/package.json b/packages/sheriff-create-config/package.json index 22f80d01..2e7df788 100644 --- a/packages/sheriff-create-config/package.json +++ b/packages/sheriff-create-config/package.json @@ -9,7 +9,7 @@ "build": "tsup", "build-watch": "tsup", "typecheck": "tsc --noEmit", - "lint": "eslint ./src --max-warnings=0 --cache --cache-location=node_modules/.cache/.eslintcache", + "lint": "eslint ./src --max-warnings=0", "publint": "publint", "typesync": "typesync --dry=fail" }, diff --git a/turbo.json b/turbo.json index 02a0e554..eecfb1d9 100644 --- a/turbo.json +++ b/turbo.json @@ -24,11 +24,9 @@ "outputs": ["node_modules/.cache/tsbuildinfo.json"] }, "lint": { - "outputs": ["node_modules/.cache/.eslintcache"], "dependsOn": ["^topo", "^build"] }, "validate-config": { - "outputs": ["node_modules/.cache/.eslintcache"], "dependsOn": ["^topo", "^build"] }, "publint": {