Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Temperature history showing incorrect numbers #494

Open
helgehatt opened this issue Jun 27, 2023 · 5 comments · May be fixed by #557
Open

[BUG] Temperature history showing incorrect numbers #494

helgehatt opened this issue Jun 27, 2023 · 5 comments · May be fixed by #557
Labels
bug Something isn't working question Further information is requested waiting for response

Comments

@helgehatt
Copy link

Describe the bug
After running an initial collect, my temperature history graph looks like this:

image

And the drive's temperature history:

  "ata_sct_temperature_history": {
    "version": 2,
    "sampling_period_minutes": 3,
    "logging_interval_minutes": 59,
    "temperature": {
      "op_limit_min": 10,
      "op_limit_max": 40,
      "limit_min": 5,
      "limit_max": 60
    },
    "size": 128,
    "index": 10,
    "table": [
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      45,
      45,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      42,
      42,
      42,
      42,
      43,
      45,
      46,
      46,
      46
    ]
  },

I can assure you that the graph is displaying the temperature in reverse order. I've been utilizing the disk in the last few hours indicated by the rise in temperature, while the dashboard displays 46 as the current temperature as well.
@helgehatt helgehatt added the bug Something isn't working label Jun 27, 2023
@helgehatt
Copy link
Author

helgehatt commented Jun 27, 2023 •
edited
Loading

Just to prove my point, here's an update a couple hours later (wiped the database and ran an initial collect again):

image

  "ata_sct_temperature_history": {
    "version": 2,
    "sampling_period_minutes": 3,
    "logging_interval_minutes": 59,
    "temperature": {
      "op_limit_min": 10,
      "op_limit_max": 40,
      "limit_min": 5,
      "limit_max": 60
    },
    "size": 128,
    "index": 12,
    "table": [
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      45,
      45,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      44,
      43,
      43,
      43,
      43,
      43,
      43,
      43,
      43,
      44,
      44,
      44,
      42,
      42,
      42,
      42,
      43,
      45,
      46,
      46,
      46,
      45,
      42
    ]
  },

You can see that the new values 45 and 42 have been added at the start of the temperature graph.

@AnalogJ
Copy link
Owner

AnalogJ commented Jul 5, 2023

Hey @helgehatt
You are kind of correct.
As seen in this temperature processing code - Scrutiny treats the first temperatures in the array as the most recent data, with the oldest at the bottom.

From my testing on Seagate, WD and Hitachi drives, that was the correct order, however I wonder if this needs to be configurable. Can you paste the full output of your smartctl run?

@AnalogJ AnalogJ added question Further information is requested waiting for response labels Jul 5, 2023
@helgehatt
Copy link
Author

Here's the full smartctl --xall output. Hopefully there's a tell in the config indicating which order it's stored.

output.json.zip

@helgehatt
Copy link
Author

Hey @AnalogJ
I’m not able to remove the «waiting for response» label, but you should be able to take a look at the smartctl output.

@psitem psitem mentioned this issue Jul 31, 2023
Closed
@helgehatt helgehatt mentioned this issue Aug 25, 2023
Open
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Dec 18, 2023
@mcarbonne
Fix AnalogJ#494
7c35063 
(not tested yet)
@mcarbonne mcarbonne linked a pull request Dec 18, 2023 that will close this issue
Open
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Jan 2, 2024
@mcarbonne
Fix AnalogJ#494
381988e 
(not tested yet)
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Jan 2, 2024
@mcarbonne
Fix AnalogJ#494
bca8876 
(not tested yet)
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Jan 2, 2024
@mcarbonne
Fix AnalogJ#494
7d50795 
(not tested yet)
@mcarbonne
Copy link

I deleted my previous comment, I was wrong (smartmontools do reorder the history when outputting json).
But I found several issues with SCT temperature history and my proposal is to simply remove this feature. #557

mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Jan 2, 2024
@mcarbonne
Fix AnalogJ#494
e70a2a0 
(not tested yet)
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Mar 17, 2024
@mcarbonne
Fix AnalogJ#494
6dd5c67 
(not tested yet)
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Mar 17, 2024
@mcarbonne
Fix AnalogJ#494
ebc4193 
(not tested yet)
mcarbonne added a commit to mcarbonne/scrutiny that referenced this issue Jun 3, 2024
@mcarbonne
Fix AnalogJ#494
29291df 
(not tested yet)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested waiting for response
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix retrieval of temperature history data (fix #494) mcarbonne/scrutiny
3 participants
@AnalogJ @helgehatt @mcarbonne