Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Whole Page Screenshot" not working for large page (with temp fix) #205

Open
terryjiang2020 opened this issue Mar 10, 2024 · 1 comment
Open

Comments

@terryjiang2020
Copy link

terryjiang2020 commented Mar 10, 2024

Describe the bug
When using the "Whole Page Screenshot" feature in a large page (e.g. the home page of Stack Overflow), the scrolling process would be finished normally, but the screenshot is not given.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stackoverflow.com
  2. Click on 1Click Screenshot => Whole Page Screenshot
  3. Wait for the scrolling process to be completed.
  4. Nothing happens afterwards, the screenshot is not showing.

Expected behavior
A new page should be opened with the screenshot.

Current Solution
This works but I have no idea why.

During the scrolling process (the page automatically scrolling down till the end of the page), keep clicking on the extension. The pop-up would open and then be closed every time the page is scrolled down again. If you keep doing that, at the end of the scrolling process, the screenshot would be shown normally.

I didn't do that intentionally at the first place btw.

Regarding the current latest version (v.46)

This solution does not work for that version, since the pop up never be closed during the scrolling process.

@terryjiang2020
Copy link
Author

Change the js/background.js:46 from speed: 400, to speed: 1000, can solve the issue. It seems the speed of making screenshots is over the permission of Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant