-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: possible collab #29
Comments
On a different but related note: I'm considering renaming the plugin to |
it is very nice by auto inject safearea CSS variables by native side,and I think it would be better if plugin could support setting CSS variable names |
Sorry, I somehow completely missed your response.
Yes, I agree, that would be a nice addition! Playing devil's advocate however, maybe allowing to customize the CSS variable names will result in less consistent implementations across Capacitor developers... Maybe some other people can chime in and give their opinion |
Nice plugin!
I was in need of a plugin that allowed me to use the edge-to-edge functionality on Android just as we're able to use it on iOS. I ended up writing this plugin: https://github.com/capacitor-community/safe-area
Only then I discovered your plugin. The approach is similar, however still a tad bit different. Some differences:
WindowCompat
- which supports older Android versions out of the box - preventing the need ofif-else
-structures and maintaining deprecated code.setOnApplyWindowInsetsListener
I'd like to hear your opinion and experience on these things. Hit me up if you want to. We could also start a collaboration if you want
The text was updated successfully, but these errors were encountered: