From 4058c09640de6419a55022c43420c56f08caf897 Mon Sep 17 00:00:00 2001
From: Dr Maxim Orlovsky <orlovsky@ubideco.org>
Date: Mon, 22 Apr 2024 16:56:51 +0200
Subject: [PATCH] isa: asm fix RegAR macro

---
 src/isa/exec.rs   |  2 +-
 src/isa/macros.rs | 60 ++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 58 insertions(+), 4 deletions(-)

diff --git a/src/isa/exec.rs b/src/isa/exec.rs
index 4d54532..ffc05d2 100644
--- a/src/isa/exec.rs
+++ b/src/isa/exec.rs
@@ -1320,7 +1320,7 @@ impl InstructionSet for BytesOp {
                     let offset = regs.a16[*offset as u8 as usize].filter(|e| *e < s_len)?;
                     let end = offset
                         .checked_add(dst.layout().bytes())
-                        .filter(|e| *e < s_len)
+                        .filter(|e| *e <= s_len)
                         .unwrap_or_else(|| {
                             regs.st0 = false;
                             s_len
diff --git a/src/isa/macros.rs b/src/isa/macros.rs
index 74cbde3..810508f 100644
--- a/src/isa/macros.rs
+++ b/src/isa/macros.rs
@@ -71,7 +71,7 @@ macro_rules! aluasm_isa {
             MergeFlag, MoveOp, PutOp, RoundingFlag, Secp256k1Op, SignFlag, NoneEqFlag
         };
         use ::aluvm::reg::{
-            Reg16, Reg32, Reg8, RegA, RegA2, RegBlockAFR, RegBlockAR, RegF, RegR, RegS,
+            Reg16, Reg32, Reg8, RegA, RegA2, RegAR, RegBlockAFR, RegBlockAR, RegF, RegR, RegS,
             NumericRegister,
         };
         use ::aluvm::library::LibSite;
@@ -220,7 +220,7 @@ macro_rules! instr {
     (extr s16[$idx:literal], $reg:ident[$reg_idx:literal], a16[$offset_idx:literal]) => {
         Instr::Bytes(BytesOp::Extr(
             RegS::from($idx),
-            $crate::_reg_ty!(Reg, $reg),
+            $crate::_reg_tyar!($reg),
             $crate::_reg_idx16!($reg_idx),
             $crate::_reg_idx16!($offset_idx),
         ))
@@ -228,7 +228,7 @@ macro_rules! instr {
     (inj s16[$idx:literal], $reg:ident[$reg_idx:literal], a16[$offset_idx:literal]) => {
         Instr::Bytes(BytesOp::Inj(
             RegS::from($idx),
-            $crate::_reg_ty!(Reg, $reg),
+            $crate::_reg_tyar!($reg),
             $crate::_reg_idx16!($reg_idx),
             $crate::_reg_idx16!($offset_idx),
         ))
@@ -1355,6 +1355,60 @@ macro_rules! _reg_tyr {
     };
 }
 
+#[doc(hidden)]
+#[macro_export]
+macro_rules! _reg_tyar {
+    (a8) => {
+        RegAR::A(RegA::A8)
+    };
+    (a16) => {
+        RegAR::A(RegA::A16)
+    };
+    (a32) => {
+        RegAR::A(RegA::A32)
+    };
+    (a64) => {
+        RegAR::A(RegA::A64)
+    };
+    (a128) => {
+        RegAR::A(RegA::A128)
+    };
+    (a256) => {
+        RegAR::A(RegA::A256)
+    };
+    (a512) => {
+        RegAR::A(RegA::A512)
+    };
+    (a1024) => {
+        RegAR::A(RegA::A1024)
+    };
+
+    (r128) => {
+        RegAR::R(RegR::R128)
+    };
+    (r160) => {
+        RegAR::R(RegR::R160)
+    };
+    (r256) => {
+        RegAR::R(RegR::R256)
+    };
+    (r512) => {
+        RegAR::R(RegR::R512)
+    };
+    (r1024) => {
+        RegAR::R(RegR::R1024)
+    };
+    (r2048) => {
+        RegAR::R(RegR::R2048)
+    };
+    (r4096) => {
+        RegAR::R(RegR::R4096)
+    };
+    (r8192) => {
+        RegAR::R(RegR::R8192)
+    };
+}
+
 #[doc(hidden)]
 #[macro_export]
 macro_rules! _reg_idx {