Use PHP's e-mail validation filter to determine if list name is valid #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm Note: https://github.com/AlternC/AlternC/blob/b5b8bc30280fe2fc2de48ffe81d70a1479038825/bureau/class/functions.php#L244 to follow checkmail() |
|
just for be sure , the '-' isn't problematic with the address create like LISTNAME-{owner|request|bounces|confirm| ..} in address table? |
|
I think in cases where the listname is something like example-owner, the actual aliases created will be
example-owner-owner, example-owner-request, etc.
If a list called exampe already exists, I think the alias example-owner will already exist and creation *should* fail.
However, this is worth confirming for sure.
…On Wed, May 08, 2019 at 01:15:59AM -0700, L-bryan wrote:
just for be sure , the '**-**' isn't problematic with the address create like LISTNAME-{owner|request|bounces|confirm| ..} in address table?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#28 (comment)
|
|
this would be interesting to fix since users usually expect to be able to have more valid characters. however, the commit that actually added the limitation in 2016, c760e7a, did so in order to avoid shell command injection within the cronjob. so if we don't want to regress back to that security issue, we should add to this PR a rewrite of the cronjob to a php script so that we avoid all of the nasty pitfalls that come from bash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27