From acd547ee9dfdaa835d9b491d0c6c66e10c01426e Mon Sep 17 00:00:00 2001 From: almenon Date: Mon, 18 Nov 2024 21:36:27 -0800 Subject: [PATCH 1/2] fix silent startup err --- src/PreviewManager.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/PreviewManager.ts b/src/PreviewManager.ts index a2444ed..379840f 100644 --- a/src/PreviewManager.ts +++ b/src/PreviewManager.ts @@ -199,9 +199,7 @@ export default class PreviewManager { // if we get spawn error here thats already reported by telemetry // so we skip telemetry reporting for this error console.error(err) - if(err.message.includes("Python was not found but can be installed from the Microsoft Store")){ - vscode.window.showErrorMessage(err.message) - } + vscode.window.showErrorMessage(err.message) }) } From 088e5e621a84910e6ce20b58421c7d89b0c92208 Mon Sep 17 00:00:00 2001 From: almenon Date: Mon, 18 Nov 2024 21:47:03 -0800 Subject: [PATCH 2/2] update error check --- src/PreviewManager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PreviewManager.ts b/src/PreviewManager.ts index 379840f..febfd62 100644 --- a/src/PreviewManager.ts +++ b/src/PreviewManager.ts @@ -187,7 +187,7 @@ export default class PreviewManager { private warnIfOutdatedPythonVersion(pythonPath: string){ PythonShell.getVersion(`"${pythonPath}"`).then((out)=>{ let version = out.stdout ? out.stdout : out.stderr - if(version?.includes("Python 3.4") || version?.includes("Python 2")){ + if(version?.includes("Python 2") || version?.includes("Python 3.4") || version?.includes("Python 3.5") || version?.includes("Python 3.6")){ vscode.window.showErrorMessage(`AREPL no longer supports ${version}. Please upgrade or set AREPL.pythonPath to a diffent python. AREPL needs python 3.7 or greater`)