Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch-seq mapping tutorial clarification #13

Open
xpliu16 opened this issue May 10, 2023 · 2 comments
Open

Patch-seq mapping tutorial clarification #13

xpliu16 opened this issue May 10, 2023 · 2 comments

Comments

@xpliu16
Copy link

xpliu16 commented May 10, 2023

  • Mapping Tasic data back to Tasic taxonomy is pretty confusing for the example. For one thing, it is unclear which things should come from the query and which from the anno. For instance, annotations$cluster and annotations$class are read in from the annotation prior to mapping, whereas I think in a more typical flow they would be read in from the metadata and mapping result? And it's only being done to subsample the data to produce a query?

  • Instead, it may be more helpful to show the preprocessing from Allen data files, including the proper log transformation of the cpm.

  • In the complete_patchseq_analysis vignette, it says to read_h5ad(file.path(refFolder,"reference.h5ad")), but tasic_2016 has only AI_taxonomy.h5ad - as pseudocode this is understandable, but not fully clear. Also, in NHP_BG_AIT_114, I initially use complete_AIT_114.h5ad instead of AIT_114_taxonomy.h5ad, which was also confusing. Would help to clarify alternative use of read_h5ad() as opposed to load_taxonomy().

  • Suggest discussing importance of filtering ROI and QC before trying to make sense of the results and suggestion for kinds of things to QC on and starting values. As I was trying to sanity check the results to see if I had run the mapping correctly, they made very little sense before doing that filtering. Of course, it is also possible that particular QC values are too aggressive and that's something the researchers should adjust on a case-by-case basis.

  • Requirements and flow for running patchseq QC aren't super clear - I'm just starting this though, and will report back more details if applicable

@jeremymiller
Copy link
Collaborator

jeremymiller commented May 10, 2023 via email

@UCDNJJ
Copy link
Collaborator

UCDNJJ commented May 10, 2023

Thanks Ping, I agree its confusing to use the same data for query and reference. Would you or someone on the PatchSeq team be willing to create a data R package with some of the published cortical patchseq samples from mouse?

This would be really helpful in the long run for scrattch.mapping documentation and examples.

We are using Tasic2016 because its very convenient to library(tasic2016data) and have some RNA-seq data :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants