Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON XOP #2253

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Update JSON XOP #2253

merged 2 commits into from
Sep 6, 2024

Conversation

MichaelHuth
Copy link
Collaborator

-one important fix here is the better handling of JSON_AddValue
for numbers that can be added as integer.

t-b
t-b previously approved these changes Sep 4, 2024
@t-b t-b enabled auto-merge September 4, 2024 16:06
@t-b t-b assigned MichaelHuth and unassigned t-b Sep 4, 2024
@t-b
Copy link
Collaborator

t-b commented Sep 5, 2024

The failure looks real.

MichaelHuth and others added 2 commits September 6, 2024 16:00
-one important fix here is the better handling of JSON_AddValue
 for numbers that can be added as integer.
This test uses PSQ_TEST_VERY_LARGE_FREQUENCY to use a frequency which
results in a very large fit slope. The update of the JSON XOP extended the
range of valid values, so we also need to use a larger value here.

The removed finite check in CheckRangeOfUserLabnotebookKeys is unfortunate
but should not be a problem.
@t-b t-b force-pushed the feature/2253-update_JSON_XOP branch from 09a69dd to ce026fa Compare September 6, 2024 14:01
@t-b
Copy link
Collaborator

t-b commented Sep 6, 2024

Fixed the CI failure. It was related to the JSON XOP, but in very edge-case way.

@t-b t-b self-requested a review September 6, 2024 14:02
@t-b t-b merged commit 99f2c0e into main Sep 6, 2024
20 checks passed
@t-b t-b deleted the feature/2253-update_JSON_XOP branch September 6, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants