Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout statements for quicker error reporting #1864

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Add timeout statements for quicker error reporting #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9649948
.github/workflows/build-pr.yml: Remove expensive_checks setting for c…
t-b Aug 30, 2023
f4340ba
.github/workflows: Add timeout_minutes parameter for IP reusable work…
t-b Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
installer_artifact_name: BuildInstaller-dev-assets
installer_flags: ${{ fromJSON('["-x skipHardwareXOPs",""]')[matrix.hardware] }} -s ${{ matrix.source }}
artifact_name: CompilationTest-${{ matrix.source }}-${{ fromJSON('["no-hardware","hardware"]')[matrix.hardware] }}-assets
expensive_checks: "1"
timeout_minutes: 60

Documentation:
name: 👷 Documentation
Expand Down Expand Up @@ -151,6 +151,7 @@ jobs:
artifact_name: test-without-hw-assets
expensive_checks: "1"
instrument_tests: ${{ fromJson('["0", "1"]')[inputs.do_instrumentation] }}
timeout_minutes: 60

TestNI:
name: 🧪 Test NI ${{ matrix.name }}
Expand All @@ -173,6 +174,7 @@ jobs:
artifact_name: test-ni-assets
expensive_checks: "1"
instrument_tests: ${{ fromJson('["0", "1"]')[inputs.do_instrumentation] }}
timeout_minutes: 180

TestITC:
name: 🧪 Test ITC ${{ matrix.name }}
Expand All @@ -195,6 +197,7 @@ jobs:
artifact_name: test-itc-assets
expensive_checks: "1"
instrument_tests: ${{ fromJson('["0", "1"]')[inputs.do_instrumentation] }}
timeout_minutes: 180

ValidateNwb:
name: 👮🏼 Validate NWBv2
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test-igor-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ on:
default: "0"
type: string
description: Sets environment variable CI_INSTRUMENT_TESTS
timeout_minutes:
required: false
default: 360
type: number
description: Defines the job timeout in minutes
defaults:
run:
shell: bash
Expand All @@ -59,6 +64,7 @@ jobs:
Test:
name: ${{ inputs.overwrite_job_name && inputs.job_name || 'Run' }}
runs-on: ${{ fromJson(inputs.target) }}
timeout-minutes: ${{ inputs.timeout_minutes }}
env:
CI_EXPENSIVE_CHECKS: ${{ inputs.expensive_checks }}
CI_INSTRUMENT_TESTS: ${{ inputs.instrument_tests }}
Expand Down