Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance adaptive suprathreshold #2302

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Enhance adaptive suprathreshold #2302

wants to merge 5 commits into from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Nov 26, 2024 •
edited
Loading

@t-b t-b self-assigned this Nov 26, 2024
t-b added 5 commits November 27, 2024 18:27
@t-b
JWN_SetWaveInWaveNote: Enhance assertion messages
1e67599 
This makes the error clearer.
@t-b
PSQ_DAScale (Adapt): Allow to look further back for passing adaptive …
70a7218 
…sweeps

The new FailingAdaptiveSCIRange analysis parameter allows to tune the
formerly hardcoded (1) number of SCIs we look back for failing adaptive
sets.

It defaults to 1, can be turned off with 0 and allows inf for always
taking all SCIs into account.
@t-b
ShowTraceInfoTags: Remove BUG messages
3834f38 
At least with IP9 BUILD: 56704 these trigger way too often to be usable.
@t-b
PSQ_DAScale (Adapt): Round calculated DAscale to integer values
1c1b367 
We don't need the sub pA precision. In PSQ_DS_GatherOvershootCorrection we
now also check if the calulated value is the same as the before/after
value, as this can now happen with rounding.

In PSQ_DS_CalculateDAScale we also use ceil for the too large/small cases
so that we always get a different value.
@t-b
WIP
886e9e6
@t-b t-b force-pushed the feature/2302-another-adaptive-revision branch from daec7e1 to 886e9e6 Compare November 27, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky will be requested when the pull request is marked ready for review timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth will be requested when the pull request is marked ready for review MichaelHuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive enhancements
1 participant
@t-b