-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DB: Fix assertion on unchecking sep.TTL with ITC hardware
since 31e201b (Util: Add GUI channel number to TUD in CreateTiledChannelGraph, 2023-07-15) When unchecking sep.TTL when using ITC hardware always the first TTL channel of the current rack range was referred as GUI channel. But actually it should be the first active GUI channel. Thus, if the first channel of a rack range was not used, then the current GUI channel was set NaN. This lead to a follow up ASSERTion when determining the correct trace color after the color index was calculated with a NaN result from the NaN GUI channelnumber. The fix is to use the first active GUI channel in the current rack range. Directly related, the axis naming for composite TTL traces was wrong as it originally referred to the hardware channel and after 31e201b referred to the first GUI channel in the rack range. This was wrong as a composite trace does not represent this channel (unless its the only one enabled). The name is now set to "TTLC" followed by a underscore separated list of active GUI channels, e.g. TTLC1_3 if TTL GUI channel 1 and 3 are enabled. Add historic data test for DataBrowser Channel Checkboxes - integrative test that checks if switching the channel checkboxes of the data browser (ADC, DAC, TTL and related) causes in some combination or transition a RTE.
- Loading branch information
1 parent
3640dfa
commit 30c26d6
Showing
3 changed files
with
82 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
Packages/tests/HistoricData/UTF_HistoricDatabrowserChannelCheckboxes.ipf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| #pragma TextEncoding = "UTF-8" | ||
| #pragma rtGlobals=3 // Use modern global access method and strict wave access. | ||
| #pragma rtFunctionErrors=1 | ||
| #pragma ModuleName=DatabrowserChannelCheckboxes | ||
|
|
||
| /// UTF_TD_GENERATOR GetHistoricDataFiles | ||
| static Function TestChannelCheckboxes([string str]) | ||
|
|
||
| string abWin, sweepBrowsers, file, bsPanel, sbWin | ||
| variable jsonId | ||
|
|
||
| file = "input:" + str | ||
|
|
||
| [abWin, sweepBrowsers] = OpenAnalysisBrowser({file}, loadSweeps = 1) | ||
| sbWin = StringFromList(0, sweepBrowsers) | ||
| CHECK_PROPER_STR(sbWin) | ||
| bsPanel = BSP_GetPanel(sbWin) | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_ADC", val = 0) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_ADC", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_ADC", val = 0) | ||
| CHECK_NO_RTE() | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DAC", val = 0) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DAC", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DAC", val = 0) | ||
| CHECK_NO_RTE() | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_TTL", val = 0) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_TTL", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_TTL", val = 0) | ||
| CHECK_NO_RTE() | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_TTL", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_splitTTL", val = 0) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_splitTTL", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_splitTTL", val = 0) | ||
| CHECK_NO_RTE() | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_DAC", val = 1) | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_ADC", val = 1) | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_TTL", val = 1) | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_VisEpochs", val = 0) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_VisEpochs", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_VisEpochs", val = 0) | ||
| CHECK_NO_RTE() | ||
|
|
||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_splitTTL", val = 1) | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_VisEpochs", val = 1) | ||
| CHECK_NO_RTE() | ||
| PGC_SetAndActivateControl(bsPanel, "check_BrowserSettings_VisEpochs", val = 0) | ||
| CHECK_NO_RTE() | ||
| End |