Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel improvements: ‘Explore an individual annotation” #9

Open
jeremymiller opened this issue Apr 19, 2024 · 1 comment
Open

Panel improvements: ‘Explore an individual annotation” #9

jeremymiller opened this issue Apr 19, 2024 · 1 comment

Comments

@jeremymiller
Copy link
Collaborator

jeremymiller commented Apr 19, 2024

Low priority fix

  • Improved color-coding. Allow more general coloring, rather than requiring a specific “direction” column in the input.
  • How to define up/down with AD (we used abundance as discussed in teach paper)? Right now we also just require a direction field, but could consider a quantitative metric of effect size, multiple columns, etc. if that makes more sense. Tain is actually rerunning the analysis: color-coding by numeric effect size instead of categorical?

Completed

  • Always show annotation value on left. Then have consistent ordering of table and chart.
  • It would also be great if the color palette was consistent (e.g. when there is only 2 levels then the "No change" becomes red vs green). RELATED: Fix the color issue on the ACE app with the up/down/none calls. Can hard-code as factors.
@jeremymiller
Copy link
Collaborator Author

I sort of fixed it so this panel can work without a metadata file, but it's a workaround. This ideally would be properly addressed still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant