Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to import 'TimeoutException' from 'e2b.sandbox' #5425

Closed
1 task done
rapturt9 opened this issue Dec 5, 2024 · 9 comments · Fixed by #5433
Closed
1 task done

[Bug]: Unable to import 'TimeoutException' from 'e2b.sandbox' #5425

rapturt9 opened this issue Dec 5, 2024 · 9 comments · Fixed by #5433
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working resolver Related to OpenHands Resolver

Comments

@rapturt9
Copy link

rapturt9 commented Dec 5, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

Using this resolver yml:


on:
  issues:
    types: [labeled]
  pull_request:
    types: [labeled]
  issue_comment:
    types: [created]
  pull_request_review_comment:
    types: [created]
  pull_request_review:
    types: [submitted]

permissions:
  contents: write
  pull-requests: write
  issues: write

jobs:
  call-openhands-resolver:
    uses: All-Hands-AI/OpenHands/.github/workflows/openhands-resolver.yml@main
    with:
      macro: ${{ vars.OPENHANDS_MACRO || '@openhands-agent' }}
      max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 150) }}
      base_container_image: ${{ vars.OPENHANDS_BASE_CONTAINER_IMAGE || '' }}
    secrets:
      PAT_TOKEN: ${{ secrets.PAT_TOKEN }}
      PAT_USERNAME: ${{ secrets.PAT_USERNAME }}
      LLM_MODEL: ${{ secrets.LLM_MODEL }}
      LLM_API_KEY: ${{ secrets.LLM_API_KEY }}
      LLM_BASE_URL: ${{ secrets.LLM_BASE_URL }}

Screenshot of error:
CleanShot 2024-12-05 at 12 04 54@2x

OpenHands Installation

Docker command in README

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

job-logs.txt

@rapturt9 rapturt9 added the bug Something isn't working label Dec 5, 2024
@tofarr
Copy link
Collaborator

tofarr commented Dec 5, 2024

Looks like there is a broken link in the resolver due to moved classes - openhands.impl.e2b.sandbox.exception.TimeoutException

@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Dec 5, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Dec 5, 2024

CC @malhotra5

@malhotra5
Copy link
Contributor

I believe this was resolved in #5409; perhaps it didn't make it into the latest release @mamoodi ?

@mamoodi mamoodi added the awaiting release Fixed in main. Waiting for release. label Dec 5, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Dec 5, 2024

Ah yep. It did not. Thank you

@note89
Copy link

note89 commented Dec 6, 2024

@mamoodi, any workaround to use the latest main?

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 6, 2024

@malhotra5 is there a way to use the latest main for resolver?

@note89 we are hoping to do another release today so hopefully will be resolved even if you can't specify main.

@enyst
Copy link
Collaborator

enyst commented Dec 6, 2024

I tried to use fix-me-experimental label, which uses main indeed, and it didn't work:
https://github.com/All-Hands-AI/OpenHands/actions/runs/12193166717/job/34014967393#step:10:46

This is a different error from the same code. One confusing detail is that e2b was updated again last night on pypi, just for fun, from 1.0.4 to 1.0.5. (lol) But that's not the reason. The reason is that our poetry.lock was still set to 0.17.1, while the resolver uses pip and its dependency resolution ended up with 1.0.5 in the run above.

Fix for the update, with pin the minimum version:

The alternative is to force e2b to 0.17 and pin it down for the resolver, until we can test it properly, together with the resolver use case, hopefully, as well as our regular CI. Maybe we could have integration tests for the resolver? So we can see these things.

@enyst
Copy link
Collaborator

enyst commented Dec 6, 2024

The PR was merged in main. Applying fix-me-experimental now starts the resolver successfully:
https://github.com/All-Hands-AI/OpenHands/actions/runs/12202046053/job/34041830904#step:10:12592

@enyst enyst mentioned this issue Dec 6, 2024
1 task
@mamoodi
Copy link
Collaborator

mamoodi commented Dec 6, 2024

This should be fixed now with the latest released version.

@mamoodi mamoodi closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working resolver Related to OpenHands Resolver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants