From 7d04297e6e4308d44d9d4c2b0ab24b2c8098aad5 Mon Sep 17 00:00:00 2001 From: Adina Parpalita Date: Thu, 6 Feb 2020 15:54:58 +0200 Subject: [PATCH] [ADF-5073] Sorted column header is incorrectly read by a screen reader (#5449) * translate column title * remove forgotten empty lines * enable screenshots for investigating weirdly failing tests * reenable the stages --- .../datatable/components/datatable/datatable.component.html | 2 +- scripts/travis/e2e/content-services-e2e.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/core/datatable/components/datatable/datatable.component.html b/lib/core/datatable/components/datatable/datatable.component.html index 0ce6580fef1..9f0311c3de2 100644 --- a/lib/core/datatable/components/datatable/datatable.component.html +++ b/lib/core/datatable/components/datatable/datatable.component.html @@ -33,7 +33,7 @@ [attr.aria-sort]="col.sortable ? (getAriaSort(col) | translate) : null" adf-drop-zone dropTarget="header" [dropColumn]="col"> {{ col.title | translate}} - {{ getSortLiveAnnouncement(col) | translate: {string: col.title} }} + {{ getSortLiveAnnouncement(col) | translate: { string: col.title | translate } }}
diff --git a/scripts/travis/e2e/content-services-e2e.sh b/scripts/travis/e2e/content-services-e2e.sh index 9e046958966..ee8b90ee51d 100755 --- a/scripts/travis/e2e/content-services-e2e.sh +++ b/scripts/travis/e2e/content-services-e2e.sh @@ -12,7 +12,7 @@ AFFECTED_LIBS="$(./scripts/affected-libs.sh -gnu -b $TRAVIS_BRANCH)"; AFFECTED_E2E="$(./scripts/git-util/affected-folder.sh -b $TRAVIS_BRANCH -f "e2e/$CONTEXT_ENV")"; node ./scripts/check-env/check-cs-env.js --host "$E2E_HOST" -u "$E2E_USERNAME" -p "$E2E_PASSWORD" || exit 1 -RUN_E2E=$(echo ./scripts/test-e2e-lib.sh -host http://localhost:4200 -proxy "$E2E_HOST" -u "$E2E_USERNAME" -p "$E2E_PASSWORD" -e "$E2E_EMAIL" --use-dist -b -m 3 || exit 1) +RUN_E2E=$(echo ./scripts/test-e2e-lib.sh -host http://localhost:4200 -proxy "$E2E_HOST" -u "$E2E_USERNAME" -p "$E2E_PASSWORD" -e "$E2E_EMAIL" --use-dist -save -b -m 3 || exit 1) if [[ $AFFECTED_LIBS =~ "testing" || $AFFECTED_LIBS =~ "$CONTEXT_ENV" || $TRAVIS_PULL_REQUEST == "false" ]]; then $RUN_CHECK