Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Automation: Comment with PR checklist when commits are pushed #240

Open
jaclyn-taroni opened this issue Sep 27, 2020 · 6 comments
Open

Comments

@jaclyn-taroni
Copy link
Member

Problem

One of the things identified as an issue in #228 is that it can be hard to verify that all conditions in the PR checklist are met when pull requests go through multiple iterations, both as a pull request author and a reviewer. It's possible that a new checklist could help a pull request author ensure that all conditions are met and give the reviewer confidence.

Idea

What if we automate a comment with a blank version of the pull request checklist? The pull request author would then edit the comment to make sure all checklist items were satisfied. The comment would get posted when commits are pushed.

Here's something I found that might be helpful: https://github.com/unsplash/comment-on-pr

If #239 happens, this could get very chatty very fast! Also, if we automate things to the point where everything other than the content changes are pretty well covered, this may be less valuable.

@cansavvy
Copy link
Contributor

I'm a tad worried about this diluting the conversations that happen on the PRs (this is highly dependent on how often people push commits. I have a tendency to push commits a lot, but I can cut back), but I do like the idea, it doesn't sound like its too hard to implement so we could give it a try and abandon it if we find it to be a nuisance.

@jaclyn-taroni
Copy link
Member Author

Yes, agreed, one would have to be cognizant of not pushing after every commit. The idea would be to push when you're ready to review the checklist again with this one.

@jashapiro
Copy link
Member

We could make it trigger on review requests?

https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull_request

on:
  pull_request:
    types: [ review_requested ]

@jaclyn-taroni
Copy link
Member Author

We could make it trigger on review requests?

This seems like exactly what we want, yes.

@cansavvy
Copy link
Contributor

cansavvy commented Oct 7, 2020

Is this something we still would like to try out? Or do we want to see how things are with the more recent automations first?

@jaclyn-taroni
Copy link
Member Author

My inclination is that the automated steps and the checklist are not mutually exclusive, and therefore this could still be useful in theory. But I agree with waiting to see how things are going in practice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants