Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readthedocs yaml file #83

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add readthedocs yaml file #83

merged 2 commits into from
Mar 4, 2024

Conversation

sjspielman
Copy link
Member

Purpose

This PR adds the .readthedocs.yaml file. Linking to RTD sooner rather than later will be good for review (see #58 (review)).

Issue Addressed

Towards #5; I will close this out issue manually after actually linking to RTD.

Any comments, concerns, or questions important for reviewers

After this goes in, I plan to formally import the repo to RTD. During that process, I'll add other folks (Jackie, Ally, Josh, David) besides me as maintainers. Are there any other specifics I'll need to know there?

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(...but you might want to make yourself a local precommit file so you can add the ending newline hook)

@sjspielman
Copy link
Member Author

but you might want to make yourself a local precommit file so you can add the ending newline hook)

💯 thanks for the reminder

@sjspielman sjspielman merged commit ac8b7ca into main Mar 4, 2024
@sjspielman sjspielman deleted the sjspielman/5-rtd branch March 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants