-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cell-type-wilms-tumor-06 workflow #827
Update cell-type-wilms-tumor-06 workflow #827
Conversation
Ah, so this is the first workflow we've used Docker in where the container doesn't have a conda environment, so |
Yes, I would rather leave the docker image alone. I don't think you should need to install conda; just a step to install
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good with just a couple minor naming/style comments.
A separate thought is if we want to track the fetusref.SeuratData
package in renv
and not install it as part of a script as we currently do. This would obviously make the docker image bigger, but save repeated downloads. (Other reference files could also potentially be installed as part of the Docker image, but this one is the easiest given current infrastructure.)
The changes to code that will affect the docker image should really be done in a separate PR... I'm sorry I was not clear about that! The reason is that the docker image has to be rebuilt and repushed, so here you are not actually testing with the new docker image (which is why this failed... the current docker image still needs you to install within the script) |
Yeah, I realized this seconds promptly after pushing but took the dog for a walk first! Going to revert here :) |
This reverts commit 1ab2d33.
…/OpenScPCA-analysis into sjspielman/824-wilms-workflow
57d11ed
into
AlexsLemonade:feature/wilms-tumor-06-azimuth
Closes #824
This PR updates the
cell-type-wilms-tumor-06
workflow file to: