Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cell-type-wilms-tumor-06 workflow #827

Conversation

sjspielman
Copy link
Member

Closes #824

This PR updates the cell-type-wilms-tumor-06 workflow file to:

  • Use Docker (note that I did also confirm just to be sure that the system dependencies needed are indeed already in the Docker container, thanks bioc base image!)
  • Use a subset of samples only when testing on PRs. I chose these samples as the ones that are specifically run through copyKAT & inferCNV, since the workflow currently evaluates these methods only on a subset of samples. This way, those samples will be present! There is nothing else particularly special about them.

@sjspielman
Copy link
Member Author

Ah, so this is the first workflow we've used Docker in where the container doesn't have a conda environment, so aws bells and whistles for downloading data aren't installed. I think the move is probably to add a step in the workflow to build the openscpca conda environment, vs adding it to Docker. @jashapiro, any other opinions on this?

@jashapiro
Copy link
Member

Yes, I would rather leave the docker image alone. I don't think you should need to install conda; just a step to install aws directly should be sufficient:

curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
unzip awscliv2.zip
sudo ./aws/install

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with just a couple minor naming/style comments.

A separate thought is if we want to track the fetusref.SeuratData package in renv and not install it as part of a script as we currently do. This would obviously make the docker image bigger, but save repeated downloads. (Other reference files could also potentially be installed as part of the Docker image, but this one is the easiest given current infrastructure.)

.github/workflows/run_cell-type-wilms-tumor-06.yml Outdated Show resolved Hide resolved
.github/workflows/run_cell-type-wilms-tumor-06.yml Outdated Show resolved Hide resolved
@jashapiro
Copy link
Member

jashapiro commented Oct 16, 2024

The changes to code that will affect the docker image should really be done in a separate PR... I'm sorry I was not clear about that!

The reason is that the docker image has to be rebuilt and repushed, so here you are not actually testing with the new docker image (which is why this failed... the current docker image still needs you to install within the script)

@sjspielman
Copy link
Member Author

The changes to code that will affect the docker image should really be done in a separate PR... I'm sorry I was not clear about that!

Yeah, I realized this seconds promptly after pushing but took the dog for a walk first! Going to revert here :)

@sjspielman sjspielman merged commit 57d11ed into AlexsLemonade:feature/wilms-tumor-06-azimuth Oct 17, 2024
3 checks passed
@sjspielman sjspielman deleted the sjspielman/824-wilms-workflow branch October 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants