Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section on managing dependencies for Python modules with conda #182

Conversation

jaclyn-taroni
Copy link
Member

@jaclyn-taroni jaclyn-taroni commented Mar 13, 2024

Stacked on #180

Which issue does this address?

Addresses the conda portion of #94.

Briefly describe the scope of the added docs file, including whether you link out to any external docs.

Here, I am essentially porting over the conda instructions from CONTRIBUTING.md, trying to match the docs style guide, and restructuring.

Will you need additional visual aids for these docs?

No.

Any other comments for reviewers?

From #169, I understand that the base environment instructions are changing. I don't believe that impacts the module-specific instructions that are included here, but please do let me know if I'm wrong.

Author checklist

Reviewer checklist

Please refer to the docs style guide while reviewing this pull request.

@jaclyn-taroni jaclyn-taroni marked this pull request as ready for review March 13, 2024 22:43
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, with only one tiny suggestion.

@jaclyn-taroni jaclyn-taroni merged commit 9e06607 into jaclyn-taroni/94-software-requirements Mar 14, 2024
1 check was pending
@jaclyn-taroni jaclyn-taroni deleted the jaclyn-taroni/94-add-conda branch March 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants