Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone the repo #113
Clone the repo #113
Changes from 9 commits
53f3f39
67f6852
151e7d9
dc6085e
ac3bbc2
ea38887
7386692
91d5c48
5deed9f
17d611c
5eb9096
d4ce3f4
1d57591
d1e025b
9a73808
73f0343
1667f5e
57ce3b0
458d72b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noting i replaced this with a smaller screenshot, it was too long before i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention anything about the difference between SSH and http here? If they have not set up SSH, they probably need to use the http version (This is what the clone from github.com will do by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sense is that things would just kind of work if they have signed into GitKraken with their github account, so I was trying to hide this "advanced" sort of information to avoid throwing too much information at them that isn't directly related to steps they need to take.
What level of detail are you proposing to add here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is quite true. GitKraken only sets up https by default, I think. If you already have SSH keys, it will use them, and it can create and update SSH keys if you ask it to, but in the most basic setting it will only set up for http.
I would just recommend that they choose http unless they have set up SSH. Basically, if you know what you are doing you can choose ssh, but otherwise you probably want http.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, took a stab at it, let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to tell people this? Why can't they change the name locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it doesn't matter, just wanted to give some guidance about how they should interact with this step. Would you suggest telling them to choose their own journey here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wouldn't specify. The video doesn't show changing the default, I don't think, so no need to mention it.