Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when processing indels #158

Open
mattiyeh opened this issue Oct 8, 2023 · 3 comments
Open

Bug when processing indels #158

mattiyeh opened this issue Oct 8, 2023 · 3 comments
Assignees

Comments

@mattiyeh
Copy link

mattiyeh commented Oct 8, 2023

this line should be start = str(int(start) - 1) without the -=

@mdbarnesUCSD
Copy link
Collaborator

Hi @mattiyeh,

Thanks for reaching out about this issue with processing ICGC files. Could you please provide an example file to showcase the behavior? Thanks!

@mdbarnesUCSD mdbarnesUCSD self-assigned this Nov 10, 2023
@mattiyeh
Copy link
Author

Hi Mark,
I'm happy to provide a sample ICGC file with indels but the error is related to a commit from 3/7/2023. The full edit back then should have also removed the - from -= in order to correctly update the value of the string start.

stomach_indel_mutations.txt

You can test the code with this sample input file.

Thanks,
Marc

@mdbarnesUCSD
Copy link
Collaborator

Hi Marc,

Apologies that we haven't been able to get to this issue yet. Were you able to find a solution for processing ICGC input files? If you have tested your changes and found a solution (also for #159), it would be great if you could open a pull request with the fix. Please let us know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants