Remove references to obsolete types

[Sbozzolo]

NCDatasets.Dimensions is no longer around as far as I can tell.

[Alexander-Barth]

It moved to CommonDataModel, but it is imported in NCDatasets from CommonDataModel.
The type NCDatasets.Dimensions is still defined (but as CommonDataModel.Dimensions)

The functions that you want to remove still work as far as I can tell.

julia> using NCDatasets

julia> NCDatasets.Dimensions
CommonDataModel.Dimensions

julia> ds = NCDataset("/tmp/foo.nc","c"); defVar(ds,"data",randn(4,3),("lon","lat"),attrib=Dict("foo" => "bar")); close(ds);

julia> ds = NCDataset("/tmp/foo.nc","a");

julia> unlimited(ds.dim)
String[]

julia> keys(ds.dim)
2-element Vector{String}:
 "lon"
 "lat"

julia> setindex!(ds.dim,123,"time")

Defining a new method on NCDatasets.Dimensions also works:

julia> foo(d::NCDatasets.Dimensions) = "bar"
foo (generic function with 1 method)

julia> foo(ds.dim)
"bar"

Can you provide a MWE what does not work for you?

[Sbozzolo]

I see this in the documentation:

https://alexander-barth.github.io/NCDatasets.jl/stable/dimensions/

[Alexander-Barth]

OK, I see now! I forgot to add the docstring to the new functions in CommonDataModel which replaced the old ones. I added them to CommonDataModel and they are now also available as keys(d::NCDatasets.Dimensions) (and similar).

The documentation should now be fixed in the dev version.

The PR should not be necessary, but thank you for your time.