From 48a4a8c74cf8e12c330f0bcf4362eaf084aa5472 Mon Sep 17 00:00:00 2001
From: Ivo Schaper <ivoschaper@gmail.com>
Date: Mon, 8 Apr 2024 14:41:01 +0200
Subject: [PATCH] add search_eval_logic fixture

---
 tests/use_cases/search/test_search.py | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/tests/use_cases/search/test_search.py b/tests/use_cases/search/test_search.py
index 777938f74..2a02a5f8a 100644
--- a/tests/use_cases/search/test_search.py
+++ b/tests/use_cases/search/test_search.py
@@ -54,6 +54,11 @@ def example(
     return Example(input=SearchInput(query=""), expected_output=expected_output)
 
 
+@fixture
+def search_eval_logic() -> SearchEvaluationLogic:
+    return SearchEvaluationLogic()
+
+
 def test_search(
     search: Search[int],
     no_op_tracer: NoOpTracer,
@@ -73,8 +78,8 @@ def test_search(
 
 def test_search_evaluation_logic_works_for_overlapping_output(
     example: Example[SearchInput, ExpectedSearchOutput],
+    search_eval_logic: SearchEvaluationLogic,
 ) -> None:
-    logic = SearchEvaluationLogic()
     output = SuccessfulExampleOutput(
         run_id="1",
         example_id="1",
@@ -88,7 +93,7 @@ def test_search_evaluation_logic_works_for_overlapping_output(
             ]
         ),
     )
-    eval = logic.do_evaluate(example, output)
+    eval = search_eval_logic.do_evaluate(example, output)
 
     assert eval.rank == 1
     assert eval.similarity_score == output.output.results[0].score
@@ -96,8 +101,8 @@ def test_search_evaluation_logic_works_for_overlapping_output(
 
 def test_search_evaluation_logic_works_for_wholly_included_output(
     example: Example[SearchInput, ExpectedSearchOutput],
+    search_eval_logic: SearchEvaluationLogic,
 ) -> None:
-    logic = SearchEvaluationLogic()
     output = SuccessfulExampleOutput(
         run_id="1",
         example_id="1",
@@ -111,7 +116,7 @@ def test_search_evaluation_logic_works_for_wholly_included_output(
             ]
         ),
     )
-    eval = logic.do_evaluate(example, *[output])
+    eval = search_eval_logic.do_evaluate(example, *[output])
 
     assert eval.rank == 1
     assert eval.similarity_score == output.output.results[0].score
@@ -119,6 +124,7 @@ def test_search_evaluation_logic_works_for_wholly_included_output(
 
 def test_search_evaluation_logic_works_for_identical_ranges(
     example: Example[SearchInput, ExpectedSearchOutput],
+    search_eval_logic: SearchEvaluationLogic,
 ) -> None:
     logic = SearchEvaluationLogic()
     output = SuccessfulExampleOutput(
@@ -134,7 +140,7 @@ def test_search_evaluation_logic_works_for_identical_ranges(
             ]
         ),
     )
-    eval = logic.do_evaluate(example, *[output])
+    eval = search_eval_logic.do_evaluate(example, *[output])
 
     assert eval.rank == 1
     assert eval.similarity_score == output.output.results[0].score
@@ -142,8 +148,8 @@ def test_search_evaluation_logic_works_for_identical_ranges(
 
 def test_search_evaluation_logic_works_for_non_overlapping_output(
     example: Example[SearchInput, ExpectedSearchOutput],
+    search_eval_logic: SearchEvaluationLogic,
 ) -> None:
-    logic = SearchEvaluationLogic()
     output = SuccessfulExampleOutput(
         run_id="1",
         example_id="1",
@@ -157,7 +163,7 @@ def test_search_evaluation_logic_works_for_non_overlapping_output(
             ]
         ),
     )
-    eval = logic.do_evaluate(example, *[output])
+    eval = search_eval_logic.do_evaluate(example, *[output])
 
     assert not eval.rank
     assert not eval.similarity_score