Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ObjectAliasTarget model #49

Merged
merged 12 commits into from
Nov 2, 2024
Merged

Conversation

Alef-Burzmali
Copy link
Owner

@Alef-Burzmali Alef-Burzmali commented Nov 1, 2024

  • Remove the ObjectAliasTarget model
  • Replace ObjectAlias.targets with ObjectAlias.prefixes, ObjectAlias.ip_addresses and ObjectAlias.ip_ranges
  • Remove unused code that supports the alias targets
  • Update the migrations to convert existing targets and create a squashed migration to skip that model in new installs
  • Update related templates and forms

The main motivations behind this change are:

  • To get rid of all the custom code that was required to make the ManyToMany GenericRelationship work without touching the ipam models
  • The ObjectAliasTarget was not always correctly recorded in ChangeLog (only an id was), which broke compatibility with the new Branching plugin.
  • The API interactions to create an ObjectAlias was clunky as you needed to manage the ObjectAliasTargets
  • The desired feature to be able to add other models in the list of possible targets via configuration turned out to be impossible to implement.

@Alef-Burzmali Alef-Burzmali merged commit 51207b7 into main Nov 2, 2024
12 checks passed
@Alef-Burzmali Alef-Burzmali deleted the dev/remove-oatargets branch November 3, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant