Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRCogitRegisterAllocatorTest vs DRLinearScanRegisterAllocatorTest #130

Open
PalumboN opened this issue Mar 21, 2024 · 3 comments
Open

DRCogitRegisterAllocatorTest vs DRLinearScanRegisterAllocatorTest #130

PalumboN opened this issue Mar 21, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@PalumboN
Copy link
Contributor

These two classes are testing the same class: DRCogitLinearScanRegisterAllocator.

Should we merge them?
@PalumboN PalumboN added the good first issue Good for newcomers label Mar 21, 2024
@guillep
Copy link
Member

guillep commented Mar 21, 2024

Hmm, I don't think so. The idea is that the linear scan register allocator has the main algorithm, the cogit one extends it with cogit specific information (interval coallescing and allocation for Division).
I'd like to keep them separate... Maybe we need a good comment :)

@PalumboN
Copy link
Contributor Author

Mmmm, then we should check if the tests are in the correct place.

@guillep
Copy link
Member

guillep commented Mar 21, 2024

Yes that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guillep @PalumboN