Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dist): include babel runtime in dist #453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dist): include babel runtime in dist #453

wants to merge 1 commit into from

Conversation

philipp-tailor
Copy link

Resolves #452.

I had to delete node_modules and yarn.lock and reinstall all packages before babel would work. If anyone gets yarn build:graphql-client to work without this drastic measure, feel free to reset yarn.lock and install @babel/plugin-transform-runtime yourself.

philipp-tailor added a commit to bird-labs/vue-cli-plugin-apollo that referenced this pull request Oct 22, 2020
@philipp-tailor
chore(dist): distribute dist
cd37e1c 
So that our fork can be used in the web app / extension until
Akryum#453 has been
merged to `vue-cli-plugin-apollo`.
@Vernando05
Copy link

@Akryum

@franciscolourenco
Copy link
Contributor

franciscolourenco commented Nov 4, 2020 •
edited
Loading

Unfortunately this fix also causes different problems when used with modern mode:

image

Which is being thrown by runtime.js:

image

@dhritzkiv dhritzkiv mentioned this pull request Dec 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'regeneratorRuntime is not defined'
3 participants
@philipp-tailor @Vernando05 @franciscolourenco