Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build workflow dependencies #219

Closed
cerrussell opened this issue Jan 10, 2023 · 1 comment
Closed

Update build workflow dependencies #219

cerrussell opened this issue Jan 10, 2023 · 1 comment

Comments

@cerrussell
Copy link
Contributor

cerrussell commented Jan 10, 2023

#220
In beginning to work on #217 , I noticed the build workflow needs to be updated to run on node16. I see that the electron builder action runs on node12. This action does not appear to be actively maintained (2 years since last update) and nobody has responded to the issue posted in October requesting the action be updated. GH plans for all actions to be migrated to node16 by this summer, so it makes sense to address this issue now before doing any new release pipeline work.

I propose replacing the existing action with this one - it's a fork where the node version is updated. I will preserve pulling from a specific commit rather than using a version tag. The other two actions are also deprecated - setup-node and checkout both need to move up to v3.

@RangerMauve
Copy link
Member

This has now been merged. Huge thanks to @cerrussell for figuring it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants