-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update send-anywhere.md #1261
Update send-anywhere.md #1261
Conversation
Various discrepancies have crept in between the docs and the code. This updates to match the code in agoric-sdk.
Deploying documentation with Cloudflare Pages
|
@@ -81,7 +81,7 @@ these functions with the necessary context (such as the contract state, logging, | |||
const orchFns = orchestrateAll(flows, { | |||
log, | |||
sharedLocalAccountP, | |||
zoeTools, | |||
zoeTools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint insistes on no-trailing-comma
, which is incorrect for our JavaScript style. Is it worth finding and fixing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not worth fixing imo
Cloudflare deployment logs are available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a walk-through for a particular source file in agoric-sdk, I think we'd be better off having this doc there. It's bound to get out of sync again otherwise.
@@ -81,7 +81,7 @@ these functions with the necessary context (such as the contract state, logging, | |||
const orchFns = orchestrateAll(flows, { | |||
log, | |||
sharedLocalAccountP, | |||
zoeTools, | |||
zoeTools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not worth fixing imo
Various discrepancies have crept in between the docs and the code. This updates the doc to match the code in agoric-sdk.