Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update send-anywhere.md #1261

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Update send-anywhere.md #1261

merged 3 commits into from
Dec 27, 2024

Conversation

Chris-Hibbert
Copy link
Collaborator

Various discrepancies have crept in between the docs and the code. This updates the doc to match the code in agoric-sdk.

Various discrepancies have crept in between the docs and the code. This updates to match the code in agoric-sdk.
@Chris-Hibbert Chris-Hibbert requested a review from turadg December 27, 2024 19:13
@Chris-Hibbert Chris-Hibbert self-assigned this Dec 27, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a67070
Status: ✅  Deploy successful!
Preview URL: https://3fa8188e.documentation-7tp.pages.dev
Branch Preview URL: https://chris-hibbert-patch-2.documentation-7tp.pages.dev

View logs

@@ -81,7 +81,7 @@ these functions with the necessary context (such as the contract state, logging,
const orchFns = orchestrateAll(flows, {
log,
sharedLocalAccountP,
zoeTools,
zoeTools
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint insistes on no-trailing-comma, which is incorrect for our JavaScript style. Is it worth finding and fixing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not worth fixing imo

Copy link

github-actions bot commented Dec 27, 2024

Cloudflare deployment logs are available here

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a walk-through for a particular source file in agoric-sdk, I think we'd be better off having this doc there. It's bound to get out of sync again otherwise.

@@ -81,7 +81,7 @@ these functions with the necessary context (such as the contract state, logging,
const orchFns = orchestrateAll(flows, {
log,
sharedLocalAccountP,
zoeTools,
zoeTools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not worth fixing imo

@Chris-Hibbert Chris-Hibbert enabled auto-merge (squash) December 27, 2024 21:21
@Chris-Hibbert Chris-Hibbert merged commit 42501e2 into main Dec 27, 2024
6 checks passed
@Chris-Hibbert Chris-Hibbert deleted the Chris-Hibbert-patch-2 branch December 27, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants