Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower-bundle-cost Done in run-chain.sh Not Needed Anymore #96

Closed
amessbee opened this issue Sep 3, 2024 · 4 comments · Fixed by #97
Closed

lower-bundle-cost Done in run-chain.sh Not Needed Anymore #96

amessbee opened this issue Sep 3, 2024 · 4 comments · Fixed by #97
Assignees
Labels
enhancement New feature or request

Comments

@amessbee
Copy link
Contributor

amessbee commented Sep 3, 2024

When we start docker, we make lower-bundle-cost target in the newly started instance of a3p to lower the cost of bundle - this is replaying proposal 61. But it seems that latest a3p instance that is used in dapp-offer-up has already lowered bundle cost as expected.
We see the following in the output when we run agd q swingset params (while make -C /workspace/contract lower-bundle-cost is commented out):

- beans: "20000000"
  key: storageByte

Therefore, it seems that we should remove the following in run-chain.sh

make -C /workspace/contract lower-bundle-cost

and corresponding targets in Makefile and in any other scripts.

@amessbee amessbee self-assigned this Sep 3, 2024
@amessbee
Copy link
Contributor Author

amessbee commented Sep 3, 2024

@dckc If this sounds ok, I will go and fix this.

@amessbee amessbee added the enhancement New feature or request label Sep 3, 2024
@dckc
Copy link
Member

dckc commented Sep 3, 2024

yes, please

@dckc
Copy link
Member

dckc commented Sep 3, 2024

please check whether https://github.com/Agoric/dapp-agoric-basics should get a similar update

@dckc
Copy link
Member

dckc commented Sep 3, 2024

Similarly, consider applying 142bf9a to dapp-agoric-basics. And dapp-orchestration-basics, if it's relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants