Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap invitation descriptions are not unique #43

Closed
samsiegart opened this issue May 20, 2024 · 0 comments · Fixed by #44
Closed

Swap invitation descriptions are not unique #43

samsiegart opened this issue May 20, 2024 · 0 comments · Fixed by #44

Comments

@samsiegart
Copy link
Contributor

samsiegart commented May 20, 2024 •
edited
Loading

Discovered in #42

The descriptions in swap invitations are not unique, so if you have multiple in your invitations purse, you can't reliably execute the invitation you want. The smart wallet will just pick the first one that matches the instance and description, which will likely result in a failed offer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use unique offer descriptions for swaps Agoric/dapp-agoric-basics
1 participant
@samsiegart