Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase test fidelity with makeWalletFactoryDriver from @agoric/boot #23

Open
dckc opened this issue Mar 15, 2024 · 1 comment
Open

Comments

@dckc
Copy link
Member

dckc commented Mar 15, 2024

The mockWalletFactory here has subtle / undocumented limitations.

export const mockWalletFactory = (

would be nice to use something like...

import { makeWalletFactoryContext } from './walletFactory.ts';

perhaps by copying that file.

The imports don't seem to be released yet or something.

$ mkdir wf
$ cd wf
$ yarn add @agoric/boot
$ ls node_modules/@agoric/boot/tools/
authorityViz.d.ts  authorityViz.d.ts.map  authorityViz.js  viz.mk

$ grep boot package.json 
    "@agoric/boot": "^0.1.1-dev-9f8a76e.0"

cc @turadg

@turadg
Copy link
Member

turadg commented Mar 15, 2024

Oh, that's because NPM for the package hasn't updated in 7 months and that's because@agoric/boot was made private 7 months ago Agoric/agoric-sdk@97d4ec5

I think the rationale was that it's not designed to be an external dependency. If we are going to publish these modules and maintain them for external consumption, I think Product should be involved. We might also want to revisit the factoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants