-
Notifications
You must be signed in to change notification settings - Fork 214
Code Review Checklist
Dan Connolly edited this page Mar 1, 2021
·
14 revisions
WIP. An initial draft based on a new team member's emerging understanding.
We delegate several checks to continuous integration tools:
- unit testing
- style, type annotation checking (lint)
But some aspects of house style are not automated:
- Object Capability Discipline - minimizing, if not eliminating, ambient authority (#2160)
- release notes; each package may use one of two styles:
- CHANGELOG.md is auto-generated from conventional commits
- NEWS.md is manual
- care with interleaving points (
await
)
See also: code-style issue label.
This wiki is for developing agoric-sdk. For help using Agoric SDK, see https://docs.agoric.com/ and https://agoric-sdk.pages.dev/