You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of #8499 (look for v14-bank-v28-provisionpool, the second section), we investigate how v43-wallet will react when it is upgraded, specifically with respect to the promises that it follows from v14-bank. These promises appear in v43-wallet in makeAssetRegistry() when it calls E(poolBank).getAssetSubscription(). This code uses observeIteration (which tolerates the decider getting upgraded/restarted), however it doesn't use a DurablePromiseWatcher, so our concern is what happens when the subscriber (v43-wallet) is upgraded/restarted.
This code is called from a prepare method, which provides evidence thaht it will be called each time v43-wallet is restarted. If so, we're good. If not, the new version of the vat might not correctly follow new assets created after upgrade.
We've already restarted v43-wallet once, in gov-49 (which activated 21-Sep-2023). I don't know if we've added any assets since then.
The task for this ticket is to test this case, ideally through a3p or some reproducible mechanism, and demonstrate that:
1: the new version of v43-wallet calls getAssetSubscription()
2: the upgraded wallet vat correctly reacts to new assets being announced by v14-bank
The text was updated successfully, but these errors were encountered:
As part of #8499 (look for
v14-bank-v28-provisionpool
, the second section), we investigate how v43-wallet will react when it is upgraded, specifically with respect to the promises that it follows from v14-bank. These promises appear in v43-wallet inmakeAssetRegistry()
when it callsE(poolBank).getAssetSubscription()
. This code usesobserveIteration
(which tolerates the decider getting upgraded/restarted), however it doesn't use aDurablePromiseWatcher
, so our concern is what happens when the subscriber (v43-wallet) is upgraded/restarted.This code is called from a
prepare
method, which provides evidence thaht it will be called each time v43-wallet is restarted. If so, we're good. If not, the new version of the vat might not correctly follow new assets created after upgrade.We've already restarted v43-wallet once, in gov-49 (which activated 21-Sep-2023). I don't know if we've added any assets since then.
The task for this ticket is to test this case, ideally through a3p or some reproducible mechanism, and demonstrate that:
getAssetSubscription()
The text was updated successfully, but these errors were encountered: