Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node-addon-api #10734

Open
turadg opened this issue Dec 18, 2024 · 0 comments
Open

update node-addon-api #10734

turadg opened this issue Dec 18, 2024 · 0 comments
Labels
enhancement New feature or request technical-debt

Comments

@turadg
Copy link
Member

turadg commented Dec 18, 2024

What is the Problem Being Solved?

node-addon-api in this module is at 1.7.1. Upstream is at 8.3.0 with many features and bug fixes

The build depends on napi-thread-safe-callback which was last published six years ago.

Description of the Design

Update deps to maintained versions.

Maybe replace napi-thread-safe-callback with [TypedThreadSafeFunction](https://github.com/nodejs/node-addon-api/blob/main/doc/threadsafe.md#napitypedthreadsafefunction

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@turadg turadg added enhancement New feature or request technical-debt labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turadg