Test Plan: v36-reserve upgrade

[iomekam]

Test Plan

Snippet of output to expect during the upgrade

2024-12-13T19:44:25.044Z SwingSet: vat: v1: coreProposal: upgradeAssetReserve
2024-12-13T19:44:25.045Z SwingSet: vat: v1: ----- UpgradeAssetReserve.2  2 ASSET RESERVE BUNDLE ID:  { bundleID: 'b1-a9adfae0bee502a8efe82385afcc2a89fd29616be0576c5b6410ee26e232a7619459f8c8bc385aa38fe82e4fb128d1f72e61559ab4159ec2965cfc36822c9a16' }
2024-12-13T19:44:26.366Z SwingSet: vat: v1: reserveKit: new Promise
2024-12-13T19:44:26.377Z SwingSet: vat: v1: reserveKit settled; remaining: [ 'anchorKits', 'bankMints', 'contractGovernor', 'reserveGovernorCreatorFacet', 'scaledPriceAuthorityKits', 'vBankKits', 'vaultFactoryGovernorCreator' ]
2024-12-13T19:44:26.491Z SwingSet: kernel: attempting to upgrade vat v36 from incarnation 0 to source b1-5ce9bb36ceb21c4af80b3c11098ac049ddfaa1898cf7a9e33d100c44f5fc68e5a14a96a5d2f9af0117929b3e5b4ab58c4a404416fb5688b03a2c0e398194e6b2
2024-12-13T19:44:30.453Z SwingSet: vat: v36: ----- AR.6  2 prepare [ 'feeMintAccess', 'initialPoserInvitation', 'marshaller', 'storageNode' ] [ 'AssetReserveKit_kindHandle', 'Durable Publish Kit_kindHandle', 'Recorder_kindHandle', 'assetReserveKit', 'feeMint', 'governorFacet_kindHandle', 'governorFacet_singleton' ]
2024-12-13T19:44:30.468Z SwingSet: vat: v36: ----- AR.6  3 awaiting feeMint
2024-12-13T19:44:30.470Z SwingSet: vat: v36: ----- ReserveKit.5  2 prepareAssetReserveKit [ 'AssetReserveKit_kindHandle', 'Durable Publish Kit_kindHandle', 'Recorder_kindHandle', 'assetReserveKit', 'feeMint', 'governorFacet_kindHandle', 'governorFacet_singleton' ]
2024-12-13T19:44:30.488Z SwingSet: vat: v36: ----- AR.6  4 awaiting handleParamGovernance
2024-12-13T19:44:30.566Z SwingSet: kernel: vat v36 upgraded from incarnation 0 to 1 with source b1-5ce9bb36ceb21c4af80b3c11098ac049ddfaa1898cf7a9e33d100c44f5fc68e5a14a96a5d2f9af0117929b3e5b4ab58c4a404416fb5688b03a2c0e398194e6b2
2024-12-13T19:44:31.443Z SwingSet: vat: v1: ----- UpgradeAssetReserve.2  3 AssetReserve upgraded:  { incarnationNumber: 1 }
2024-12-13T19:44:31.444Z SwingSet: vat: v1: ----- UpgradeAssetReserve.2  4 Done.

Key text to look for:

• UpgradeAssetReserve
• vat: v36: ----- AR.6 2 prepare signifies that we are within buildObjectRoot for the reserve upgrade
• vat: v36: ----- ReserveKit.5 2 prepareAssetReserveKit
• UpgradeAssetReserve.2 3 AssetReserve upgraded: { incarnationNumber: 1 }
• UpgradeAssetReserve.2 4 Done.

[Chris-Hibbert]

With the AssetReserve, we're going to want to verify that assets weren't lost in the upgrade on the testNets (if any) and on MainNet. I think that means we'll need to take a look in vstorage before the upgrade for every platform. (Is there another way to tell post facto?)

Please check with someone who handles upgrades (@toliaqat? @otoole-brendan ) and see how we should prepare for that.