-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trigger slog events for timer and install bundles #10332
Comments
Yeah, that sounds reasonable to me. If it's easy, I'd add I think Tell me more about "messages/acks info on |
I believe all that is included in the
Yeah whatever the return value is. The name is
I'm talking about the |
closes: #10332 closes: #8272 refs: #9569 ## Description Adds slog events for the bundle install and timer poll run triggers. Add more context to the bridge and deliver inbound triggers. Fixes the otel trace processing of upgrade events. ### Security Considerations None ### Scaling Considerations This adds a little more data to our slogs, but relatively minor compared to the amount of data we already generate. ### Documentation Considerations None ### Testing Considerations The integration test has limited coverage of the otel slog processor. I will repurpose #9569 to add testing in a3p, but in the mean time this change cannot affect operations and at worse the modification are not sufficient to our needs. ### Upgrade Considerations Requires a chain software upgrade but the changes do not affect consensus and could be locally cherry-picked.
What is the Problem Being Solved?
Timer polls and install bundles generate swingset runs (possibly empty), but unlike "bridge" and "deliver" (mailbox) triggers, we do not record a trigger event for these. This forces any contextualized slog processor (e.g. #10269 or #8680) to peek ahead at the first delivery to classify the type of run. We should also consider including more details in the existing trigger to enhance the classification.
Description of the Design
cosmic-swingset-timer-poll
slog event. Include theblockTime
of the poll, and the number of wakes added to the queue.cosmic-swingset-install-bundle
slog event. Include theendoZipBase64Sha512
of the bundler, and anyerror
.cosmic-swingset-bridge-inbound
slog events.cosmic-swingset-deliver-inbound
slog eventsTo avoid future regressions with missing triggers for swingset runs, we should consider plumbing this into
runSwingset()
somehow.Security Considerations
None
Scaling Considerations
A little extra/duplicated data, but very little in comparison of the rest of the slog size.
Test Plan
Manual is good enough
Upgrade Considerations
Requires a change of the chain software, but it does not affect consensus.
The text was updated successfully, but these errors were encountered: