Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing members should not be able to propose #10136

Closed
otoole-brendan opened this issue Sep 24, 2024 · 4 comments
Closed

Outgoing members should not be able to propose #10136

otoole-brendan opened this issue Sep 24, 2024 · 4 comments

Comments

@otoole-brendan
Copy link
Contributor

otoole-brendan commented Sep 24, 2024

What is the Problem Being Solved?

Outgoing members should not be able to propose

Design

Security Considerations

Scaling Considerations

Test Plan

  • Unit test for the shutdown method (makeZoeForTest, startInstance, get the creatorFacet, call shutDown; then try to make an invitation to propose a parameter change)
  • Bootstrap test: test that when an outgoing member tries to propose, they get an error
  • a3p-integration test for upgrading the contract

Upgrade Considerations

yes. See design, test plan.

@otoole-brendan
Copy link
Contributor Author

@frazarshad @rabi-siddique could you please estimate?

@rabi-siddique
Copy link
Contributor

A revision to econCommitteeCharter.js to add a shutdown method

This has been completed today.

Work for the core eval script and tests remain.

@frazarshad
Copy link
Contributor

Currently, outgoing members have the invitation that can propose, but they cannot propose through the econ-gov-ui due to Agoric/dapp-econ-gov#131

@otoole-brendan
Copy link
Contributor Author

Not planned - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants